Re: git: 7ca4bf132765 - main - devel/ncurses: Do not strip libraries when DEBUG option is set

In reply to: Ganael LAPLANCHE : "git: 7ca4bf132765 - main - devel/ncurses: Do not strip libraries when DEBUG option is set"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Thu, 02 Jun 2022 13:31:44 UTC

On Thu, Jun 02, 2022 at 10:21:53AM +0000, Ganael LAPLANCHE wrote:
> commit 7ca4bf13276577544841a58c208e9b3fd7230b9a
> 
>   devel/ncurses: Do not strip libraries when DEBUG option is set
>     
> @@ -95,7 +95,9 @@ post-install:
>  	${RM} ${STAGEDIR}${PREFIX}/lib/libncurses.so
>  	${ECHO} "INPUT(libncurses.so.${PORTVERSION:R} AS_NEEDED(-ltinfo))" > ${STAGEDIR}${PREFIX}/lib/libncurses.so
>  
> +.if ! ${PORT_OPTIONS:MDEBUG}
>  	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/*.so.${DISTVERSION}
> +.endif

Correct fix is to drop the DEBUG option and wrap --with-debug with
.if defined(WITH_DEBUG).  ${STRIP_CMD} respects WITH_DEBUG by itself
via Mk/b.p.m.  See `mail/mailutils' as an example.

./danfe