git: 6fd5ce4b2ae8 - main - graphics/svgalib: prevent "make all" from deleting files
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 20 Jul 2022 15:53:03 UTC
The branch main has been updated by se:
URL: https://cgit.FreeBSD.org/ports/commit/?id=6fd5ce4b2ae8c7df72cc97f7303a99a7b14915d7
commit 6fd5ce4b2ae8c7df72cc97f7303a99a7b14915d7
Author: Stefan Eßer <se@FreeBSD.org>
AuthorDate: 2022-07-20 15:46:14 +0000
Commit: Stefan Eßer <se@FreeBSD.org>
CommitDate: 2022-07-20 15:52:49 +0000
graphics/svgalib: prevent "make all" from deleting files
The Makefile provided with this software made "make install" imply
"make uninstall" as a pre-condition. This caused the installation of
files to the stage directory to be preceded by the removal of those
files from the base system.
This is unacceptable behavior for a port: no files outside of the
work directory and possibly $TMPDIR (i.e. /tmp) must be affected by
"make all" to build a port.
This issue did not affect building a package in poudriere, since
there were no installed files to delete, and the generated package
was correct. Therefore, the PORTREVISION has not been bumped.
Reported by: Andy Farkas <andyf@andyit.com.au>
---
graphics/svgalib/files/patch-Makefile | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/graphics/svgalib/files/patch-Makefile b/graphics/svgalib/files/patch-Makefile
index 0226ac6691e3..c550ea64439d 100644
--- a/graphics/svgalib/files/patch-Makefile
+++ b/graphics/svgalib/files/patch-Makefile
@@ -36,3 +36,12 @@
@echo "Installing keymap utilities in $(bindir):"
@echo "svgakeymap: Perl script that generates scancode conversion maps."
@cp utils/svgakeymap $(bindir)
+@@ -261,7 +259,7 @@ installman:
+ installman:
+ (cd doc; $(MAKE) -f $(srcdir)/doc/Makefile srcdir="$(srcdir)" install )
+
+-install: uninstall $(INSTALLAOUTLIB) installheaders $(INSTALLSHAREDLIB) installconfig \
++install: $(INSTALLAOUTLIB) installheaders $(INSTALLSHAREDLIB) installconfig \
+ $(INSTALLSTATICLIB) $(INSTALLUTILS) $(INSTALLMAN)
+ @echo
+ @echo