Re: git: 6a6c45fae02b - main - textproc/yelp-xsl: use 'gnome' dir not 'gnome3'

From: Mathieu Arnold <mat_at_freebsd.org>
Date: Sat, 02 Jul 2022 14:46:42 UTC
On Fri, Jul 01, 2022 at 06:36:02PM +0000, Neel Chauhan wrote:
> The branch main has been updated by nc:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=6a6c45fae02b647bece42cd9613e2fe42560b7ed
> 
> commit 6a6c45fae02b647bece42cd9613e2fe42560b7ed
> Author:     Neel Chauhan <nc@FreeBSD.org>
> AuthorDate: 2022-07-01 18:34:49 +0000
> Commit:     Neel Chauhan <nc@FreeBSD.org>
> CommitDate: 2022-07-01 18:34:49 +0000
> 
>     textproc/yelp-xsl: use 'gnome' dir not 'gnome3'

This (and all the commits like this one, which should probably have been
done as one commit anyway) really need to explain WHY you do things.
Really Neel, many people have asked you to explain why you do things in
commit messages.

Right now, what it does is force everyone to re-download all those
distfiles, and nothing is gained by anyone.  Nobody cares the directory
where the distfiles are stored, one can probably guess than if the
directory is "gnome" or "gnome3" it is related to gnome.

> ---
>  textproc/yelp-xsl/Makefile | 2 +-
>  textproc/yelp-xsl/distinfo | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/textproc/yelp-xsl/Makefile b/textproc/yelp-xsl/Makefile
> index 8a64322a30a8..18effb687589 100644
> --- a/textproc/yelp-xsl/Makefile
> +++ b/textproc/yelp-xsl/Makefile
> @@ -4,7 +4,7 @@ PORTNAME=	yelp-xsl
>  DISTVERSION=	42.0
>  CATEGORIES=	textproc gnome
>  MASTER_SITES=	GNOME/sources/${PORTNAME}/${PORTVERSION:C/^([0-9]+)\..*/\1/}
> -DIST_SUBDIR=	gnome3
> +DIST_SUBDIR=	gnome
>  
>  MAINTAINER=	gnome@FreeBSD.org
>  COMMENT=	DocBook XSLT stylesheets for yelp
> diff --git a/textproc/yelp-xsl/distinfo b/textproc/yelp-xsl/distinfo
> index c299ca1bea99..38a3fd4f0234 100644
> --- a/textproc/yelp-xsl/distinfo
> +++ b/textproc/yelp-xsl/distinfo
> @@ -1,3 +1,3 @@
> -TIMESTAMP = 1656533012
> -SHA256 (gnome3/yelp-xsl-42.0.tar.xz) = 29b273cc0bd16efb6e983443803f1e9fdc03511e5c4ff6348fd30a604d4dc846
> -SIZE (gnome3/yelp-xsl-42.0.tar.xz) = 663824
> +TIMESTAMP = 1656700465
> +SHA256 (gnome/yelp-xsl-42.0.tar.xz) = 29b273cc0bd16efb6e983443803f1e9fdc03511e5c4ff6348fd30a604d4dc846
> +SIZE (gnome/yelp-xsl-42.0.tar.xz) = 663824

Side note, the TIMESTAMP should not have changed as the distfile itself
has not.

-- 
Mathieu Arnold