From nobody Fri Jan 14 21:07:24 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E80D2194A3A9; Fri, 14 Jan 2022 21:07:27 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JbDQR5J97z3R4H; Fri, 14 Jan 2022 21:07:27 +0000 (UTC) (envelope-from se@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642194447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LGRrBTpv6djcSJ0Sil6N2JdkpAzivV9Sa7K22qAIuaw=; b=rW8X5yBiNTiauuThtaubj8+cWlZ526WhM8RWw9xYACmltf2cWcdIb4aRVm+6bhqWrnX7Ey pa+6QfkqQjb6GaP2XpMnT1VT5x0wLO03jrAALpJeQjZr+N0tgR0Xr9uASdaNOwwVagD911 okSR6sTXLUfefkRM0aYz7EHqTSbwMI6hqh1VxS+NRaIHNG0kqIirzDDJYGbNJgdKosMiP8 Tc2XhsndO4Id5rTOAtUCYwhYOZIG6yd4AQN0VRaL5q8pokEBT9IVBKYvzhg9kqm54ua0Id q/Jea39+hO4u/7bJhlcroYEm8xfZtrQ80bJtUlS96Hwga4sOq+hstkOHmkF+IQ== Received: from [IPV6:2003:cd:5f13:2400:6b:2428:7065:f0c2] (p200300cd5f132400006b24287065f0c2.dip0.t-ipconnect.de [IPv6:2003:cd:5f13:2400:6b:2428:7065:f0c2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id C5C78A379; Fri, 14 Jan 2022 21:07:26 +0000 (UTC) (envelope-from se@FreeBSD.org) Message-ID: Date: Fri, 14 Jan 2022 22:07:24 +0100 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: git: bcaf25a8c804 - main - Fix CONFLICTS entries of multiple ports Content-Language: en-US To: Gerald Pfeifer Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202201101516.20AFGNau035475@gitrepo.freebsd.org> From: Stefan Esser In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------uxEP2USgUcaJ0wwWQqqIBPyY" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642194447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LGRrBTpv6djcSJ0Sil6N2JdkpAzivV9Sa7K22qAIuaw=; b=XfEiNh8blGQaNNhTtmNmu67WQxxfrVPh/vGiZWx0cta9JpdfwoCaVtcrZtqpAmsbddPUko ei+TuRy82VfzPT/MvWTG/Jk6Szc1hq7DCu+hPXvr+/Tn0+ls8P6ZoVDq+chaNBAfhZTbIJ xbVkr0ruNGAZFU0Ggh/t4EnlDTlpxnZ8yfuM0lVRO8ppGX/ceIk9iaSUzDXFxIS5IdCt/l hDbJ5R/mumqxJqSNjViKSWJ9xltxFSvHqH8olI+8kxzYIW4JEuGl40vrZSjlns1igSFK6q gtrIusOK/elopZt0ozrcyQdhGhVqhhmRdkhBeE7Z59j5I0/sOuwb46qQNgH3Ng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1642194447; a=rsa-sha256; cv=none; b=rNbcJJVO14+ZFI66JYSICGZF0gKpAd3W75FxFTG8dDHEnqzojaF0sZUI+d4uIKOqH1g/iu 7MohQNexED4reuiUkBS4EidA5uhWxDCllZVJKTpNgLdOT5NSiHA4y7i6b4l64z3oByKmQ2 tSHO1/O1wTVnKExRgSkxr8byLLrLss/zYycCbyYJI2oy3ZTqvHOFcmhXDBfqhEEiRlDx1Z /mriVT/qUvg513rfa95WfXvp+eytB76iJejzCj1SKBMCHttXhJL+JzyDeZDoO0nsgnIn0o qrHm2X4G/C/0wg9+Rqv9eEXPGBXZmZJIJqUowOExX0uFX3Q6acDRNJhsaUIwIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------uxEP2USgUcaJ0wwWQqqIBPyY Content-Type: multipart/mixed; boundary="------------YowFdYraELxYHWJWMWq5dhd9"; protected-headers="v1" From: Stefan Esser To: Gerald Pfeifer Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Message-ID: Subject: Re: git: bcaf25a8c804 - main - Fix CONFLICTS entries of multiple ports References: <202201101516.20AFGNau035475@gitrepo.freebsd.org> In-Reply-To: --------------YowFdYraELxYHWJWMWq5dhd9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 14.01.22 um 10:46 schrieb Gerald Pfeifer: > On Mon, 10 Jan 2022, Stefan E=C3=9Fer wrote: >> Where possible, version numbers in conflicts entries have been >> generalized, some times taking advantage of the fact that a port >> cannot conflict with itself (due to logic in bsd.port.mk that >> suppresses the pattern match result in that case). >=20 > Indeed, the "a port cannot conflict with itself" part is one I did > fail to understand in the past, unless you and me chatted a bit. ;-) >=20 > I believe it would be helpful if > https://docs.freebsd.org/en/books/porters-handbook/book/#conflicts > had an explicit note that a package does not conflict with itself. Yes, we had discussed this point before, and I do agree that the description in the handbook is easily mis-understood, leading to unnecessarily complex CONFLICTS entries. There are two reviews that I have prepared to fix the conflicts checks in bsd.port.mk to not ignore conflicts for the same port directory (including all FLAVORs of a port), but only for the same package base name: https://reviews.freebsd.org/D31151 (for all pkg versions) https://reviews.freebsd.org/D32694 (for pkg>=3D1.17.2 only) I have only now noticed that bapt@ has accepted the latter review, but I did not want to commit it until pkg-1.17.2 (released 2021-09-21) can be assumed to be installed on all relevant systems. Since these commits will change the details of CONFLICTS processing, I'll wait with an update of the documentation until either of these reviews has been accepted. But I can prepare a review of the planned documentation change, now ... Regards, STefan --------------YowFdYraELxYHWJWMWq5dhd9-- --------------uxEP2USgUcaJ0wwWQqqIBPyY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmHh5gwFAwAAAAAACgkQR+u171r99UQd XAgAr08CZrdxXCsOHpTW22Jxn8n9LVhldQMikD9UFjn2lSMEMiyDu11SuGZR4lyJM+D6FnM+ju2E ucf03qgXO0z22lpIH2G6VbPLY0H8Q//Rx3rLx83MnyGdGa9n1dIX/bleIycDSjwRCmE8Mkp2cv7Y Z/+hIQbTKqZUmBjahWD57bEm8rG9JqkOpWfIdYQLKc2Cj9iFcUkisesbM3vW5EJmyEC/KgOzd7ln vGIuOIC8JAkQHqDxR9kCLJoEFcazFJaHJWTUH6c2XYRZT5n0K+jh572YiuUYuMTjgD7wVVxUGgyJ dgLKEt9L19AQhR/HYA5Vlp4fJ5YhqBcF3tg8S/Bgxw== =LF6g -----END PGP SIGNATURE----- --------------uxEP2USgUcaJ0wwWQqqIBPyY--