Re: git: 74615207da3d - main - audio/wavplay: fix ONLY_FOR_ARCHS
Date: Wed, 12 Jan 2022 13:43:01 UTC
Hi,
this is wrong. If there is endianness issue, why is powerpc64le removed?
Either the issue is something else (and ONLY_FOR_ARCHS_REASON needs to be fixed) or powerpc64le should be readded.
On 22-01-12 12:50:45, Dmitry Marakasov wrote:
> The branch main has been updated by amdmi3:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=74615207da3d4e9b707ef5713256456bcd19d6c3
>
> commit 74615207da3d4e9b707ef5713256456bcd19d6c3
> Author: Dmitry Marakasov <amdmi3@FreeBSD.org>
> AuthorDate: 2022-01-12 11:02:38 +0000
> Commit: Dmitry Marakasov <amdmi3@FreeBSD.org>
> CommitDate: 2022-01-12 12:44:23 +0000
>
> audio/wavplay: fix ONLY_FOR_ARCHS
>
> - Remove powerpc* from ONLY_FOR_ARCHS, which were incorrectly added
> on a sole basis that the port builds. It needs to be runtested.
> - Add ONLY_FOR_ARCHS_REASON to prevent such mistake in future.
>
> PR: 261061
> ---
> audio/wavplay/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/audio/wavplay/Makefile b/audio/wavplay/Makefile
> index bfc5c7a82577..d16999356e4d 100644
> --- a/audio/wavplay/Makefile
> +++ b/audio/wavplay/Makefile
> @@ -12,7 +12,8 @@ COMMENT= Wav player and recorder
> LICENSE= GPLv2 # only
> LICENSE_FILE= ${WRKSRC}/COPYING
>
> -ONLY_FOR_ARCHS= amd64 armv6 armv7 i386 powerpc64 powerpc64le
> +ONLY_FOR_ARCHS= amd64 armv6 armv7 i386
> +ONLY_FOR_ARCHS_REASON= does not play sound correctly due to endian issues
>
> CFLAGS+= -D_WANT_SEMUN
>