From nobody Mon Feb 14 11:59:38 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CFFF519B9DE2; Mon, 14 Feb 2022 11:59:41 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jy2p55YtHz4qVh; Mon, 14 Feb 2022 11:59:41 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644839981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=98GUJIVMGH0rEAu03CxqwsOTUQ6IIDCvad5CCwT8uX0=; b=SaqAy75NS4+Dqalk7Pe3odHOOkhM3R5QqBSobG4aReRCP6IDQMxvpt8T/ZX7liImGbNlZt W+487SQLoIogseHoqab4JI+TLTBK4Pi7XZQLV4gMhYysBOhAwq3UUz74iXDjUr24Bghpts WLUY2dm3JPtA8pVRrQFlCd9QYor7gvRd0qBUQswVFlfEOuTQVzynDbX09PkoBfUsTZUF4U L4HUghg+X8/tuwpkCVYgo1NUFyT7sh7GEltTT/nXuL+YeXSjZGxzcApbHxHphkc+SB0kQA HhjUdfyllLrV3kJq6u/GSFp3y/89+kqab01UCeOi2dVCL4WR16UI0cNDDHDGrw== Received: by freefall.freebsd.org (Postfix, from userid 1354) id A25BC10C31; Mon, 14 Feb 2022 11:59:41 +0000 (UTC) From: Jan Beich To: Piotr Kubaj Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 98b88b839df1 - main - x11/cde: actually fix build on powerpc64le References: <202202141141.21EBfLVh090770@gitrepo.freebsd.org> Date: Mon, 14 Feb 2022 12:59:38 +0100 In-Reply-To: <202202141141.21EBfLVh090770@gitrepo.freebsd.org> (Piotr Kubaj's message of "Mon, 14 Feb 2022 11:41:21 GMT") Message-ID: <4k51-slp1-wny@FreeBSD.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644839981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=98GUJIVMGH0rEAu03CxqwsOTUQ6IIDCvad5CCwT8uX0=; b=AbrdJwv1uOQQWy0h6bMp5JqO8JlsGtO0iJ2Ze3Niysc7QGMRR4SXydwZgzt5uj/D3nwNVB 8qhgk9T9RTHaNNeQwHUVwYNKHuMP8gjrxh+RGrZFWlK/OE/daC9uYB5vF/2ZKSkajotPnD VOZw9zgjXEnfUWWfK7LkxqwYFDGHmtyzRZkQ9O1Xeopx+EpLoA7ArC+c49O9cdG1D6YTtL n4sBQiFfHzSgQ38Vj7iA22A1olSXV0KG+yMPGOsvyPL5Tk6ez2WjKh1uS3xkXgXPhPEM3w u2DTDTixOFvW177cvOIJXe5aYiBH7WuvGHAAK/INcoHBzW/JnJyYwrjLmOHcBg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644839981; a=rsa-sha256; cv=none; b=lADmRwykxvz3eJGTIHf+eb40XSp+MzouxISyGrFywHwNIFGJTBr+FHq5g0qRMwrfRuueQX 3Y4DQ1tvp6jLaavumWf2xKDy8U90agMs6RnbOM7+GenVGOiu1GUooC9FmAn1xrszWXQ5EH HXyqqKtjvI8Gz6CvtGO9eO3b5FhBf12zHUtG6FsInoAiIra/Lq8296Sp+ADlfzUIKDlmh1 sQGM6aJ6szR6CZ9p+icewBlHOqLTSbKkeFdBPkCFHIajV0eG46kKgSODij4BLyGx5b7VGp fU/IyVQp0P7iJpWqVKyvikWKstgCDS3LgCm0FehzAT0w8x7zbWe32KxOKK16kA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Piotr Kubaj writes: > The branch main has been updated by pkubaj: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=98b88b839df1a88f538b8bfdc74e9734b0df7ea3 > > commit 98b88b839df1a88f538b8bfdc74e9734b0df7ea3 > Author: Piotr Kubaj > AuthorDate: 2022-02-14 11:38:50 +0000 > Commit: Piotr Kubaj > CommitDate: 2022-02-14 11:38:50 +0000 > > x11/cde: actually fix build on powerpc64le > > This port doesn't respect setting FLAGS via Makefile, so -DPOWERPC64LE goes unnoticed. > > Switch to ifdef __powerpc64__. [...] > -.if ${ARCH} == powerpc64le > -CPPFLAGS+= -DPOWERPC64LE > -.endif [...] > -+#ifdef POWERPC64LE > ++#ifdef __powerpc64__ > + tmpval = va_listval(va_arg(ap, va_listarg)); > + va_copy(ap, tmpval); > +#else > + va_copy(ap, va_listval(va_arg(ap, va_listarg))); > +#endif Do you intentionally ignore endianess here? __powerpc64__ is defined on both big (aka ARCH=powerpc64) and little (aka ARCH=powerpc64le).