From nobody Fri Dec 30 08:55:57 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Njzcx2tQ8z2kZWc; Fri, 30 Dec 2022 08:56:01 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Njzcw6RZ5z3p7D; Fri, 30 Dec 2022 08:56:00 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTP id AwQcpavFAl2xSBBBHpUReq; Fri, 30 Dec 2022 08:55:59 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id BBBGprvBIyAOeBBBGproGE; Fri, 30 Dec 2022 08:55:59 +0000 X-Authority-Analysis: v=2.4 cv=e5oV9Il/ c=1 sm=1 tr=0 ts=63aea79f a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=sHyYjHe8cH0A:10 a=6I5d2MoRAAAA:8 a=q8G9rIWDAAAA:8 a=NEAV23lmAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=7S4ySwrYVzp1Kq7nio0A:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=DI3MkeQ2y9KdeWGcMs14:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id B9B188814; Fri, 30 Dec 2022 00:55:57 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 82EC232C; Fri, 30 Dec 2022 00:55:57 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Nuno Teixeira cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: f9080cec69db - main - x11-wm/nscde: Replace expired ksh2020 dependency, Remove DEPRECATED In-reply-to: <202212300841.2BU8f4sd059400@gitrepo.freebsd.org> References: <202212300841.2BU8f4sd059400@gitrepo.freebsd.org> Comments: In-reply-to Nuno Teixeira message dated "Fri, 30 Dec 2022 08:41:04 +0000." List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 30 Dec 2022 00:55:57 -0800 Message-Id: <20221230085557.82EC232C@slippy.cwsent.com> X-CMAE-Envelope: MS4xfAhrAJFPVH+NYJI5IIfbsz1FZ46VYwMvCAV53am+YDF6LtPAC9vKpAWJyD/8TD+bkGn0I1JvY3dd6KkVG1ZHMyFOY2yrbD2OGOSKMlzyHrFra47RYcm9 qWUV+02k4mKhp9OWzwExQG9rsJHEcrtptiY9TlmFncJiNLIZUCDVsmBMDOCJD+8DDAfLP5X5Kia6pWHsmYJnq7WBK2SOUL7dMQ0PhfqC0o/WM3mU91jJQ33X qgzVBh6AhYtGed7/TVr19RVM8LyQ8/SHMLwg9VWPw0U26OlXfdflHpT9wvb7l+AEwi3AQwWNm7o2YkEYnkeWBRzAf9AQTpvrpGYGQ6Aewrc= X-Rspamd-Queue-Id: 4Njzcw6RZ5z3p7D X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N In message <202212300841.2BU8f4sd059400@gitrepo.freebsd.org>, Nuno Teixeira wri tes: > The branch main has been updated by eduardo: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=f9080cec69db09ce08dc72da892cc8 > 30fdbfe231 > > commit f9080cec69db09ce08dc72da892cc830fdbfe231 > Author: Chris Moerz > AuthorDate: 2022-12-30 08:36:08 +0000 > Commit: Nuno Teixeira > CommitDate: 2022-12-30 08:40:33 +0000 > > x11-wm/nscde: Replace expired ksh2020 dependency, Remove DEPRECATED > > - add LICENSE_FILE > - fix avoiding use of != in assignments > > PR: 267501 > MFH: 2022Q4 > --- > x11-wm/nscde/Makefile | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/x11-wm/nscde/Makefile b/x11-wm/nscde/Makefile > index 101e986ba64a..19db82204080 100644 > --- a/x11-wm/nscde/Makefile > +++ b/x11-wm/nscde/Makefile > @@ -1,5 +1,6 @@ > PORTNAME= nscde > DISTVERSION= 2.2 > +PORTREVISION= 1 > CATEGORIES= x11-wm > MASTER_SITES= https://github.com/NsCDE/NsCDE/releases/download/${DIST > VERSION}/ > > @@ -8,9 +9,7 @@ COMMENT= Modern CDE clone based on fvwm > WWW= https://github.com/NsCDE/NsCDE > > LICENSE= GPLv3 > - > -DEPRECATED= Depends on expired shells/ksh2020 > -EXPIRATION_DATE=2022-12-31 > +LICENSE_FILE= ${WRKSRC}/COPYING > > BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}psutil>=5.7.0:sysutils/py-psutil > @${PY_FLAVOR} \ > ${PYTHON_PKGNAMEPREFIX}xdg>0:devel/py-xdg@${PY_FLAVOR} \ > @@ -19,7 +18,7 @@ BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}psutil>=5.7.0:sy > sutils/py-psutil@${PY_FLAV > font-bh-lucidatypewriter-100dpi>0:x11-fonts/font-bh-lucidatypew > riter-100dpi \ > fvwm2:x11-wm/fvwm2 \ > gsed:textproc/gsed \ > - ksh93:shells/ksh2020 \ > + ksh93:shells/ksh93 \ shells/ksh is the continuation of the ksh2020 development. I think you'll want that. CDE, for instance tests for the existence of the ksh and ksh93 binaries. If nscde does the same you may consider testing it with that port. However I'm pondering on flavorizing the three ksh's to allow them to coexit if you prefer to wait/discuss. They currently implement this using option helpers. shells/ksh93 is the no longer developed legacy AT&T AST ksh, with all of its warts and bugs should a script depend on them. shells/ksh and shells/ksh-devel are based on a GH project (ksh93/ksh) that was forked from ast/ksh when AT&T AST shut down that development and moved the development to the ksh2020 branch for safe keeping. The developers at the time forked ast/ksh to continue development under their own project. So, I think you probably want shells/ksh. Hope this helps. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0