From nobody Thu Dec 29 13:10:35 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NjTKL08S8z1Lg5P; Thu, 29 Dec 2022 13:10:46 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NjTKK2ZbTz417t; Thu, 29 Dec 2022 13:10:45 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Authentication-Results: mx1.freebsd.org; none Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id CB1151CEEAA; Thu, 29 Dec 2022 14:10:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=anongoth.pl; s=ANONGOTH; t=1672319436; bh=Gku+vyWCbSjfS4dznc+B7x0ZnjK5RdDUDHXo9Ng9a7c=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=o/FFy6ZOWBqELtlACi7lovxSYnyZfWL4Uyl+MDmBBVpLjQjQeAj0pPJ1orNyjs8U+ 9ok8v22kzHD17vTBLNSIQ5Uw9ZG+4rcpcCZFdFzmtIuiaWLdykSyYpDasypAbletB+ tHragd7vrc8/ww/rSxOinUTI896G9+TV2RSzoIqRuG8ki6K0GR6D89kdvbkXT3h/38 rFR3zE7x+jQFkO6KVIFZTxNJZKHXvYtCk+Xd2Wg0CgBIWbcBQuoq8Q/MCb6DjCgUKx nVuahpykcctwDva+SmRewUMqxt61NHKOAX6zNby7YWBufqYHdRi63EJu2DB+lA++97 acTLEo7B2I41Q== Date: Thu, 29 Dec 2022 14:10:35 +0100 From: Piotr Kubaj To: Nuno Teixeira Cc: Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 Message-ID: References: <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6r8wC0gHyxtDxRHn" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4NjTKK2ZbTz417t X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --6r8wC0gHyxtDxRHn Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Nope. You can use the maintainer's version. If you append USES=3Dcompiler:c++14-lang for everyone, then without omp.h there will be USES=3Dcompiler:c++14-lang compiler:gcc-c++11-lib (two compiler parameters). I have tried that in the past and it doesn't work, only the first one will be used. On 22-12-29 09:31:44, Nuno Teixeira wrote: >maintainer is trying to "force" me to use: > >--- >.if !exists(/usr/include/omp.h) >USES+=3D gcc-c++11-lib >.else >USES+=3D compiler:c++14-lang >.endif >--- > >But I think we can avoid .else statement and use compiler:c++14-lang on >"normal" USES since compiler will be overrided by the .if condition. >Am I correct? > >Piotr Kubaj escreveu no dia quinta, 29/12/2022 =C3=A0= (s) >01:52: > >> Yes, that is ok. >> >> On 22-12-29 00:26:01, Nuno Teixeira wrote: >> >(...) >> > >> >Got confused with that commit that have some months old. >> > >> >Current Makefile has: >> >--- >> >.if !exists(/usr/include/omp.h) >> >USES+=3D compiler:c++14-lang >> >USE_GCC=3D yes >> >.else >> >USES+=3D compiler:c++14-lang >> >.endif >> >--- >> >And it should be corrected to: >> >--- >> >.if !exists(/usr/include/omp.h) >> >USES+=3D compiler:gcc-c++11-lib >> >.endif >> >--- >> > >> >Is that ok? >> >Sorry because I've got confused >> > >> >Nuno Teixeira escreveu no dia quarta, 28/12/2022 >> =C3=A0(s) >> >23:59: >> > >> >> You have fixed it in >> >> >> https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121= a2e745ed4293 >> >> >> >> I think I understand it better now >> >> >> >> Thanks >> >> >> >> Piotr Kubaj escreveu no dia quarta, 28/12/2022 >> =C3=A0(s) >> >> 13:43: >> >> >> >>> It would and I was against removal of USES=3Dcompiler:openmp but it = was >> >>> done anyway without any regard for architectures that don't have >> libomp. >> >>> >> >>> On 22-12-28 14:15:44, Thierry Thomas wrote: >> >>> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj >> >>> =C3=A9crivait : >> >>> > >> >>> >> If OpenMP is still necessary, then the best way would be: >> >>> >> .if !exists(/usr/include/omp.h) >> >>> >> USES+=3D compiler:gcc-c++11-lib >> >>> >> .else >> >>> >> USES+=3D compiler:c++14-lang >> >>> >> .endif >> >>> > >> >>> >It would be great to re-add an argument "openmp" in Mk/Uses/ >> compiler.mk >> >>> >to put this kind of code at a central place. >> >>> >-- >> >>> >Th. Thomas. >> >>> >> >> >> >> >> >> -- >> >> Nuno Teixeira >> >> FreeBSD Committer (ports) >> >> >> > >> > >> >-- >> >Nuno Teixeira >> >FreeBSD Committer (ports) >> > > >--=20 >Nuno Teixeira >FreeBSD Committer (ports) --6r8wC0gHyxtDxRHn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmOtkcswFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydLdwP/0CXuTnpYMVjG2Hvx7l3++LR8u5hGDv5JXLmpVXCvw0Sd+xAZiDl7+CZ /o0V88IsIQUXL0y6hf9HlSk75Kj6OC2+ust1yLcV+j2sCn98QEO8XoQJnwwa2ipg SNoyfOynRumrzfHv2F8PyqlO7zHY+GR1aIHI8nczdjanbsk6G/ylSP/fMloSLDK7 aV/MLnYyQRkjl1Ln/u7EB3caKubP3yIycpo5NCaKlEvSlOvS0z7asq+DCvdkv6Nd gZrS7hzL4/94sNnWx8NwAr1RC4NoKbUtraZURBIQxCSqehvUyQwdqx2bdWymD8Ea l01cseX+HUisXRs4kSTF0tNYd6831B23mCFY9wbg1qJ0r70dMQs8gxDtI79oIc0b AeyHZBBgcs2FMdwR4IKiFXaMakHjDa52Eobsj9Gx6eoYPMucNIteyHYHWxUcDUT7 QJi4ZTOup0SlrY+DgzFyMWeHVrZy0iGmpqBsslN4V5KE8TQDbsg5kV5ItK+nuEws OeGoxoiGS+8+6bdpwkofopqUdT5EbinABqFSzpmaj9Rv9mU5GOh7WwWwE+da9OjY 7i874y57MdSyAXV+muf+xUjshIxbrTozn1J6uTDrx9P99EP2nFuZVawJTc6B119v xQNVmq74/F84Y8aA2Vbd/D6pJB67j1wjnhdyAoUVypGB/67oto22 =Lw9f -----END PGP SIGNATURE----- --6r8wC0gHyxtDxRHn--