From nobody Thu Dec 29 01:52:22 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NjBGp3zvSz2krYN; Thu, 29 Dec 2022 01:52:34 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NjBGp1M7gz401X; Thu, 29 Dec 2022 01:52:34 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Authentication-Results: mx1.freebsd.org; none Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 65E031CD03D; Thu, 29 Dec 2022 02:52:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=anongoth.pl; s=ANONGOTH; t=1672278744; bh=uNUdeVC51uiBOHB0FuUCpaw3yRtJdl3hH7ipUAhxCgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=mnGiAMaeRlTwywtCgsCd4RrIVH1MiSY/GtAw8llahuY74iGzKy8oCo2tRlkIqwZcd dvxlPWXc8qXPGehj3Nva52TXhS4LeYpGIB1Cvfwa2fIURwiufGT/NLpsnmV80I7gDY 42huUbN9Jz2Wn8YVL2m7fKDJcmu7rmHLib81q3kSfveXL/3VHJUdh1WFT68cYEgsa6 s64L0r3QftEp72c6Z/sWKOC+O92/cwAGu2jjqNENMzRggBXtUHFFrM30/6SM27akLN yVuxgSNe+YmyUbQG94Wn1AWnN9G+1XlsMaiGpqYxNz38+Xz4FsZALohUza/xKVf7L7 6YKR5crct2QBA== Date: Thu, 29 Dec 2022 02:52:22 +0100 From: Piotr Kubaj To: Nuno Teixeira Cc: Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 Message-ID: References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v0wLhvsWberFI2bV" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4NjBGp1M7gz401X X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --v0wLhvsWberFI2bV Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Yes, that is ok. On 22-12-29 00:26:01, Nuno Teixeira wrote: >(...) > >Got confused with that commit that have some months old. > >Current Makefile has: >--- >.if !exists(/usr/include/omp.h) >USES+=3D compiler:c++14-lang >USE_GCC=3D yes >.else >USES+=3D compiler:c++14-lang >.endif >--- >And it should be corrected to: >--- >.if !exists(/usr/include/omp.h) >USES+=3D compiler:gcc-c++11-lib >.endif >--- > >Is that ok? >Sorry because I've got confused > >Nuno Teixeira escreveu no dia quarta, 28/12/2022 =C3= =A0(s) >23:59: > >> You have fixed it in >> https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121= a2e745ed4293 >> >> I think I understand it better now >> >> Thanks >> >> Piotr Kubaj escreveu no dia quarta, 28/12/2022 =C3= =A0(s) >> 13:43: >> >>> It would and I was against removal of USES=3Dcompiler:openmp but it was >>> done anyway without any regard for architectures that don't have libomp. >>> >>> On 22-12-28 14:15:44, Thierry Thomas wrote: >>> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj >>> =C3=A9crivait : >>> > >>> >> If OpenMP is still necessary, then the best way would be: >>> >> .if !exists(/usr/include/omp.h) >>> >> USES+=3D compiler:gcc-c++11-lib >>> >> .else >>> >> USES+=3D compiler:c++14-lang >>> >> .endif >>> > >>> >It would be great to re-add an argument "openmp" in Mk/Uses/compiler.mk >>> >to put this kind of code at a central place. >>> >-- >>> >Th. Thomas. >>> >> >> >> -- >> Nuno Teixeira >> FreeBSD Committer (ports) >> > > >--=20 >Nuno Teixeira >FreeBSD Committer (ports) --v0wLhvsWberFI2bV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmOs8tYwFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydDJoP/iRFqTrfeo7VhbMZlCIr+kLewUX7q1xX1K+Pfez/z4LmNjeRwa89YVIn LWk9/3dFHg+a0WozbMnslWBqp/BJvCiDZALqEOlPPTdbmLMdObvepufItZpQdA1R XbBOFDaJlPBaJGzNzW3BLpU2Z+/6Od1s/7+rnquiZo5lol/CLrAmN9H7dUVB4Xac nt2ouMuYouOEbDuUttDaYMqy9/Rlc+fnkpLjSqe7fEJYmCwx8bc7/lHoNEEZmAj3 8X4tekstC/879dA4eoeiH6945YCnpkXYMXKSVY1h5MC6Gn4ryHeevTE+4pfegXYz l431BrQKgG5/jqGycXgzbwxYtNI4OgEodLZY0vQJXnIlYTZxkRyi3MYRmhs+rpjR dj/U44GIiKpu13pDChcL3kTQDZg95WvB2ijFSqK16N3aqVBsFe1oS3Tmp+4BiRap Vuqo35068Hup+ZgIWITy/qFWEasPP8gFENPVGzC0DUgahVQA/1eREC9RZnVB1Zyb Eg5GVdamXFrMbzoxOOe+SsJa/nnIfjtOwbuzf+JCLGeCIfMn+3YK6Je/ruW1+d78 8zRBxWSo7PbAgg9lcswVqYgAgJg7Z1MQikkB607xvq8hY3ukcg739VosAZzemzhP k51LV3qGE3pTR7XopDZcN2zrAyGY3UlvTp/5fD9ErFp82+70aCfq =SiSH -----END PGP SIGNATURE----- --v0wLhvsWberFI2bV--