From nobody Wed Dec 28 23:59:48 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nj7mw4nhfz2kZR8; Thu, 29 Dec 2022 00:00:00 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nj7mw4P2vz3k6q; Thu, 29 Dec 2022 00:00:00 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672272000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Hh/SSGB78LhNO+SJ/vpJJ4KvhbLWzHbXVSmgRpVXck=; b=lbC2BNACOx9KUArmumn6uE1CVR5Ai1GFJFI8VIESd67A/ttR/CwaiNxzSo1/wjw7EMZcLJ sUvRowWbrjBjO5gsMtLSnuvJXF1Pap0LSou3Ue+lsNTLYZL0IOrnYOvQILVRZOTL1W56G2 9JzUzCfptZg9q60C6E/V/0XS4jIEwr9+KazrWT1Ew3UKUApB0g+WOKOmeqq3f9ok286tPH /NHRCa7ui6tu4PdIP+9J87Y5c556fgGszzHR2Sd7JftNi2bX4XJ+h7WF3j0enrhGH0bk13 ObK6lo4020jlbm24SPgGFAe9uzS0fXBBgJW7sQ8lqS2DvJ75RsKt1orhopGT3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672272000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Hh/SSGB78LhNO+SJ/vpJJ4KvhbLWzHbXVSmgRpVXck=; b=PdAWO/wAHEYap6lC5+as0tB+ijex2GgxyXZnHCxlj3fCfsDS4KPvOC65yN6EY83Dm7lwU0 okOLZZ9y8fjXTnRnlk56mFXv3CWu9vuB1FQQf0qBNbPm4GlDMTFCAo3xZ47sZqxlMis0tm 8ycT2lhVN4KIHICOwbLDXR8+uJxxxvpEV+WpwGEBHZcX12mANDrAGmn10/g83Lee6e/Bw1 /4j8NE9nryjnE9UBQtnS8kX/Y4xQYe+vE17WNxew7YeHkmYwI5K0E/ToupnISSCNuxPFT3 JImWzf76wOk/z5gH78G/Djoa8TokIOvU8AwVODAd3Y1wgWj2+JY79MV1lB5ITw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672272000; a=rsa-sha256; cv=none; b=vVjg4bihhfg7/oOpb+h8oVfrgORm/fJNJia9PLgTFTNMEhs2G8/KaKHyHddAMOhiD8PGoo 3wYSIDGy/o5S1dWXoCkNGIsoZA+HzcoU3XUUQTVs43znZK+nzDay+zF9QKCxLGOY+KVngZ oz0CXTmEhxv0TfzKDTqVni2lpEFd23Y415yRbkRYWz+YDeiG8jvaITmrZwh5r1KOmcO9IP r0JKWmyKkdmJ11w2OVcrfPCyqSk3e0rARg8JQ/SROA0wUa7970+96jrtPm+t22+pWihCmV dGQOPJxRcRL7K39Al/eOtigPhuF/NemZT/UZQWt5HK00V0IGz9rVmbY4J85oKQ== Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Nj7mw3Lpwzbtp; Thu, 29 Dec 2022 00:00:00 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-vs1-f54.google.com with SMTP id p30so11377580vsr.1; Wed, 28 Dec 2022 16:00:00 -0800 (PST) X-Gm-Message-State: AFqh2kq+e6wmMczYJuMF18kXRS8NQ/Xav9ZUyjKwSRB5JN9ywp+1nz6l nOxMCMVlzlLQNTtEpMGcDTQuE9RoXQkYMNiyMAE= X-Google-Smtp-Source: AMrXdXsiS8VRRvqUkj7wXsy+/IgJaYCu2g6VzZeSvrx4fkw5YZW2ZwK8Skj58lS/KNwyEWceexPjUbcU/3T4hmI6ftU= X-Received: by 2002:a67:f450:0:b0:3b5:23b1:e56 with SMTP id r16-20020a67f450000000b003b523b10e56mr3557145vsn.51.1672271999871; Wed, 28 Dec 2022 15:59:59 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> In-Reply-To: From: Nuno Teixeira Date: Wed, 28 Dec 2022 23:59:48 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 To: Piotr Kubaj Cc: Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000008530b405f0ec2a7c" X-ThisMailContainsUnwantedMimeParts: N --0000000000008530b405f0ec2a7c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable You have fixed it in https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121a2e= 745ed4293 I think I understand it better now Thanks Piotr Kubaj escreveu no dia quarta, 28/12/2022 =C3=A0(= s) 13:43: > It would and I was against removal of USES=3Dcompiler:openmp but it was > done anyway without any regard for architectures that don't have libomp. > > On 22-12-28 14:15:44, Thierry Thomas wrote: > >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj > =C3=A9crivait : > > > >> If OpenMP is still necessary, then the best way would be: > >> .if !exists(/usr/include/omp.h) > >> USES+=3D compiler:gcc-c++11-lib > >> .else > >> USES+=3D compiler:c++14-lang > >> .endif > > > >It would be great to re-add an argument "openmp" in Mk/Uses/compiler.mk > >to put this kind of code at a central place. > >-- > >Th. Thomas. > --=20 Nuno Teixeira FreeBSD Committer (ports) --0000000000008530b405f0ec2a7c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quarta, 28/12/2022 =C3= =A0(s) 13:43:
It= would and I was against removal of USES=3Dcompiler:openmp but it was
done anyway without any regard for architectures that don't have libomp= .

On 22-12-28 14:15:44, Thierry Thomas wrote:
>Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj <pkubaj@anongoth.pl>= =C3=A9crivait=C2=A0:
>
>> If OpenMP is still necessary, then the best way would be:
>> .if !exists(/usr/include/omp.h)
>> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:gcc-c++11-lib
>> .else
>> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:c++14-lang
>> .endif
>
>It would be great to re-add an argument "openmp" in Mk/Uses/<= a href=3D"http://compiler.mk" rel=3D"noreferrer" target=3D"_blank">compiler= .mk
>to put this kind of code at a central place.
>--
>Th. Thomas.


--
Nun= o Teixeira
FreeBSD Committer (ports)
--0000000000008530b405f0ec2a7c--