Re: git: 145ca5487348 - main - audio/openal-soft: fix build with lld 15 on i386

On 12/25/22 13:13, Dima Panov wrote:
> Moin-moin!
> 
> On 25.12.2022 20:54, Dimitry Andric wrote:
>> The branch main has been updated by dim (src committer):
>>
>> URL: 
>> https://cgit.FreeBSD.org/ports/commit/?id=145ca54873489e7d45eac99de62f733a54dc294d
>>
>> commit 145ca54873489e7d45eac99de62f733a54dc294d
>> Author:     Dimitry Andric <dim@FreeBSD.org>
>> AuthorDate: 2022-12-20 22:28:41 +0000
>> Commit:     Dimitry Andric <dim@FreeBSD.org>
>> CommitDate: 2022-12-25 17:53:21 +0000
>>
>>      audio/openal-soft: fix build with lld 15 on i386
> [skip]
> 
>> +.include <bsd.port.pre.mk>
>> +
>> +# The following is actually meant for lld 15.0 and later, but the ports
>> +# framework does not support LINKER_TYPE and LINKER_VERSION yet.
>> +.if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 150
>> +# Turn off checking of dynamic relocations, to avoid lld diagnostics 
>> about
>> +# possibly incorrect addend values.
>> +LDFLAGS_i386+=    -Wl,--no-check-dynamic-relocations
>> +.endif
>> +
>>   PLIST_SUB=    SOVERSION=${PORTVERSION}
>>   OPTIONS_DEFINE=        CONFIG EXAMPLES JACK OSS PORTAUDIO PULSEAUDIO \
> 
> Looks like 1) misplased .pre.mk include and corresponding section
> 2) not closed with .post.mk
> 
> This breaks OPTIONS settings (always sets to off due misconfig) and 
> caused unneded rebuild of consumers
> 
> 

This also broke my amd64 build all together, so it definitely needs to 
be adjusted.

sean