From nobody Mon Dec 19 15:29:04 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NbNsZ5Z3mz1G0sZ; Mon, 19 Dec 2022 15:29:06 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NbNsZ55ypz3GB6; Mon, 19 Dec 2022 15:29:06 +0000 (UTC) (envelope-from bofh@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671463746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cFSWoasa9NcHoQKzSmlF/83vzQoMrc9G5LpAsmYWD28=; b=mYDSIAYHM0FOzKWzTzTGd3GRi9N2zJAETusVx019/mZsjPBUgACzgzrOWLgFDfyRJN7c1a RAmwvVJeCCdn82b+uGxXOmly+ZMCvlmwPGAkarH37nGE5KMZ4aRrPxko2Rq7TixrI9rm9y NuDiJ9OHGqcheZFh/qwOinhDC7AuzLKXAvrEnl1KdyIzyz2wotw9veHdYP1OTXhSRmLGiK XLvDsf5RHzDdt7EY8JX7IMeYWLYi6YtXzzPmhIy+hc9zM4Y0LTbTpWr13REsodL6ciFhAO 7OMR275C8oMfxMr9KVJT7HPYk0BEl5WRmN+1x2tl1GzNEfKE4O8bN+G1DVJyCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671463746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cFSWoasa9NcHoQKzSmlF/83vzQoMrc9G5LpAsmYWD28=; b=QkEZa4IIyizSneSLej7HyxDlcTOk6mlvJ2PBxiIoEaZke0nXVZegq2sqViODTvwrUWrhak k7rOWdSJ1DSws9ovHm5DPT4qx8flm0ULeetkFH/VobnNDz7nYIrUlHYV6iZMs0lGERAhiP wJlW0+1nwV8x31ZFsxCO6icZULvVvhqaTulW1UVd7hjGN3Yg5/J1LsCcSRT5Iazrhu7MrK T1tj+QRESJVHnrfWFCZx943RXVz/h5pekmwRyKq/9gus14tMypBkeamltu5hI5PQwRQi4T TplTbyk6oEwbk81veH2ToKlMNdBiz/xdk2kLDLs0124sT9uBSKESBHF03G6sVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1671463746; a=rsa-sha256; cv=none; b=kFfOb0fbl66Fn/g/UUhbL25ZvwQOh5beJEfEuPlJaBbIHh0hZ5sYbCEbRMTc/eePeq1puz qpL+1RF6GH681t8+iwwAgU7YDY7JxwaBC5cTsiBxaKER1polrYPkA6ttwPvo9O+zWcXRfV udbcSLrSUsMllDjk/pKxonDmA+QOz03dDvXRXkTbdLfpCCaKT4G/QSDmHWRSENTPy1AqtY KVT9F3mU4xSSrjXbdEPNk2fU5QbDIEM6e3A0A5QD6NoPJ1JRiQ7xqdUP6Vv7i6o3hDw+oZ 7ShmWduIZmXVdjxg5dyIU0QuWeOc/xjv9lf/RkoMdfUc63UdvKtRPbK+1pu/rA== Received: from mx.bofh.network (mx.bofh.network [IPv6:2a0d:2787:2::28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.bofh.network", Issuer "R3" (verified OK)) (Authenticated sender: bofh/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NbNsZ0KQszj8Q; Mon, 19 Dec 2022 15:29:05 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtpclient.apple (gw.office.cyso.net [95.97.78.194]) by mx.bofh.network (OpenSMTPD) with ESMTPSA id 705f8f31 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 19 Dec 2022 15:29:04 +0000 (UTC) From: Moin Rahman Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_9841338B-8B3F-4E34-BA30-A31248DDB675"; protocol="application/pgp-signature"; micalg=pgp-sha512 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 721e5776c957 - main - Mk/**tex.mk: Convert bsd.tex.mk to USES=tex Date: Mon, 19 Dec 2022 16:29:04 +0100 In-Reply-To: <706F6533-8545-44DE-84DB-363E2F4DE628@freebsd.org> Cc: "ports-committers@freebsd.org" , "dev-commits-ports-all@freebsd.org" , "dev-commits-ports-main@freebsd.org" , portmgr To: Renato Botelho References: <202212191445.2BJEjAJ9012677@gitrepo.freebsd.org> <48d155ae-5afc-0b47-5e8f-ef1fe98e2e18@FreeBSD.org> <706F6533-8545-44DE-84DB-363E2F4DE628@freebsd.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_9841338B-8B3F-4E34-BA30-A31248DDB675 Content-Type: multipart/alternative; boundary="Apple-Mail=_1109EDAC-C037-469B-954B-08D16D5A3C3E" --Apple-Mail=_1109EDAC-C037-469B-954B-08D16D5A3C3E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Dec 19, 2022, at 4:20 PM, Moin Rahman wrote: >=20 >=20 >=20 >> On Dec 19, 2022, at 4:06 PM, Renato Botelho = wrote: >>=20 >> On 19/12/22 11:45, Muhammad Moinur Rahman wrote: >>> index cf49b696640c..57a1c21cb16e 100644 >>> --- a/lang/mlton/Makefile >>> +++ b/lang/mlton/Makefile >>> @@ -83,8 +83,9 @@ MAKE_ARGS=3D DESTDIR=3D'' = MLTON_VERSION=3D${PORTVERSION} \ >>> .if ${PORT_OPTIONS:MDOCS} >>> BUILD_DEPENDS+=3D htmldoc:textproc/htmldoc >>> MAKE_ARGS+=3D MLTON_BINARY_RELEASE_WITH_DOCS=3Dtrue >>> -#USE_TEX=3D latex:build >>> -USE_TEX=3D latex:formats >>> +USES+=3D tex >>> +USE_TEX=3D latex:build >>> +#USE_TEX=3D latex:formats >>=20 >> This change seems wrong, it used to have latex:formats before and not = it has latex:build. >>=20 >> -- >> Renato Botelho >>=20 >=20 > There was no keyword like :formats in the previous bsd.tex.mk = and neither there were any checks on the validity of the keywords. :v >=20 > I think the descriptions are still a bit confusing and I need some = help describing it more profoundly. >=20 > In the file there is a description section formats and listing some = tex formats which somehow uses the text like `formats:` and some formats = but that colon is to list the separate formats not something like = formats:. In addition to that there is in fact a keyword formats = which also has a valid ARGS like test|build|run|extract|lib to mean the = dependency on print/tex-formats rather than individual formats. In case = it's required to have a dep on those listed formats the keyword of the = name of the format should be used. >=20 > I think I have been able to describe it properly but in case not feel = free to advise if by anyhow I can improve the descriptions in the file. >=20 > Kind regards, > Moin >=20 By the by in addition to those mentioned in case you are not happy with = my explanation; I did check all the consumers(At least I tried my best; = I might have missed one or two which I will fix in case I see them = pkg-fallout) with the new infra and here are the result for this = specific port: https://pdr.bofh.network/data/latest-per-pkg/mlton/20210816/131-tex.log = Kind regards, Moin --Apple-Mail=_1109EDAC-C037-469B-954B-08D16D5A3C3E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Dec 19, 2022, at 4:20 PM, Moin Rahman <bofh@freebsd.org> = wrote:



On Dec 19, 2022, at 4:06 = PM, Renato Botelho <garga@FreeBSD.org> wrote:

On 19/12/22 11:45, Muhammad Moinur Rahman wrote:
index = cf49b696640c..57a1c21cb16e 100644
--- = a/lang/mlton/Makefile
+++ b/lang/mlton/Makefile
@@ -83,8 +83,9 @@ MAKE_ARGS=3D DESTDIR=3D'' = MLTON_VERSION=3D${PORTVERSION} \
.if = ${PORT_OPTIONS:MDOCS}
BUILD_DEPENDS+=3D = htmldoc:textproc/htmldoc
MAKE_ARGS+=3D = MLTON_BINARY_RELEASE_WITH_DOCS=3Dtrue
-#USE_TEX=3D = latex:build
-USE_TEX=3D latex:formats
+USES+=3D tex
+USE_TEX=3D = latex:build
+#USE_TEX=3D = latex:formats

This = change seems wrong, it used to have latex:formats before and not it has = latex:build.

--
Renato = Botelho


There = was no keyword like <FORMAT>:formats in the previous bsd.tex.mk = and neither there were any checks on the validity of the keywords. :v

I think the descriptions are still a bit = confusing and I need some help describing it more profoundly.

In the file there is a description section = formats and listing some tex formats which somehow uses the text like = `formats:` and some formats but that colon is to list the separate = formats not something like formats:<ARGS>. In addition to that = there is in fact a keyword formats which also has a valid ARGS like = test|build|run|extract|lib to mean the dependency on print/tex-formats = rather than individual formats. In case it's required to have a dep on = those listed formats the keyword of the name of the format should be = used.

I think I have been able to describe = it properly but in case not feel free to advise if by anyhow I can = improve the descriptions in the file.

Kind = regards,
Moin


By = the by in addition to those mentioned in case you are not happy with my = explanation; I did check all the consumers(At least I tried my best; I = might have missed one or two which I will fix in case I see them = pkg-fallout) with the new infra and here are the result for this = specific port:

Kind = regards,
Moin

= --Apple-Mail=_1109EDAC-C037-469B-954B-08D16D5A3C3E-- --Apple-Mail=_9841338B-8B3F-4E34-BA30-A31248DDB675 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmOgg0BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA vJG3YQ//c9jc03kLVnOadBABj+7LNSDJlv0MWTkyo1Ntv8VVXb9BMecWNQIUM2gB xeH0T5aXhKceEhzrIrzPItcyORBzF/ixEcQ1SmhaXWr3p77W2+KcCkZ7vG7m41EF H95vDG2jW0UpwiAq8ZkuzgSmX3Xjq4J02kg92u34TSo/S6rJF4NjYWVJPg9hvs+j Ww5k33R9REtd6HlvN9t3TqrxNbyRd4XQuJZfh+HofSFCq4XdXO5uUdpr321v7eFE i7Gla90RmOlLVwp8ov68qYFNzSq+EvCD49jQ2HZBcw3k/dzDVKPwvym0x4HcP9um WkedSlTpukS/PxPaEeUyAqjRvnhblT17PtXTGmjiL5JU8uCJXCfEp04EuTzT89J+ lromQ5pGuSBFsZF+SlSEcalihSCm4yNaicNB6Op/7oRNZ9POzwgsQQF7YwnTnQHI ay9sgWGRXIn0rsSrHuOo4MMCYDq7zw1xWvRzp7fN+PQSmW48c2sDB7FBXorW2UW9 jcxUExfjHS62h2TNXgret/gvl81jsEeYS8i772xW+Agv1bom0tLnwy1iw9ACuPTP 4ur1geqPxuwK9sEBt/33orPusjG2Y6GkRh93ts1WcQasxmRNlvHekNb7rXI+P1gK LzBBRQu5w6HdINBAPFYiXJkaewUHjd3U/NsSF8ll6ygbYc+SowA= =fK5b -----END PGP SIGNATURE----- --Apple-Mail=_9841338B-8B3F-4E34-BA30-A31248DDB675--