From nobody Mon Dec 12 15:32:25 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NW5Gf1tdjz4kd08; Mon, 12 Dec 2022 15:32:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NW5Gf1S60z3D94; Mon, 12 Dec 2022 15:32:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670859146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f/Da3ZykK4nhR0OCGF08YiksazwRoJsOSdkGuDyXVK0=; b=j/nY6T4HXxEObtGnZXxrQJvTUiRwTmC8jRm7CohFAAhZYWCsS1qnAV4JBb09fWQ4I2ygy7 Y33647NR4Axbt3mfvtu7AkOByHW3mwrDhhejJuI03mhm5D/1jlLYrg0JxWDIVHnxMsKgWh EgrgvEF5weEbpFeh3u7NKa52NKzHNkPU1c4juPQ5yGQBetg9frYgHdwgUngsDG8pMbJjbY TU7ARU0ctsIoqA2AN2E53RjfXVqomRiA/tz0N/lhZMyu/gXSAZRW/j2pD5Prc++qsbTvIR HXCo12qbR3JnFAwzwHx5zRkhJCR8Q95348NtFDygMLAVP5eWtqtIPJAwaHrg3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670859146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f/Da3ZykK4nhR0OCGF08YiksazwRoJsOSdkGuDyXVK0=; b=OcXgZRqVErjkY7KxYkt3NCYeVx/+eXDOD6LA1gNG0FQUV7mJqd7meX6/cVQ1FOpAc8ectk oLyP+s5O6NGJ3Y6EEQNfU88uBRajnBuLxkRLE/Izg4UnbUgZcE51T2YQ3bMUiLugf9Qo8W iU0JTiy9fvKJZagQVLLvCARctZZN0RtzYz0MK/S7994il5x6TksruoU+bAtY3s/LRSOeaS rqPVgkW2zPPcbtt3WehFGl72KQ/8VPbt5CRV32TiVs9GR2HRpNcE6cqlFizjAzA1sTNQtd 1HHZJSSpZ1UQEALAvGYKd9WMZb6ut5CBJ+IW5/H88ipDG0lCL+hEvJv45c9V0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670859146; a=rsa-sha256; cv=none; b=u/fRbKe8ZRmt8OOPaAei4SGLt56x5k1JB8rDrtzsLnHrxVLF4f4EXI8IokCWCHoOF2nKSh AAacHdHruFQF3uGtUDbn56ixkGN+ZyKzHEWuqF0koLSAoqVULjjpuofFMNYbMVYmwRPo76 5/JDRgLlYsq1o/Z4X7ef7NNHQgYRFrw3Yj613isZu9p0nPZrUf1nH8RepGd1TUXzhwJNdl v0XUXYnUJNVLEXko9JKcLU+ApFy8x7LQx+3Lg2z9GI3ztruZ/cm3bt83e6oSeRamHGuAN0 /gjyecy4A8Ut5Gd7vfUY232emd3dIbTrBwAhGlxTRh1XD0kvMCbtEsqe9pkr9w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NW5Gf0VlMzfkb; Mon, 12 Dec 2022 15:32:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2BCFWPoX057012; Mon, 12 Dec 2022 15:32:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2BCFWPC4057011; Mon, 12 Dec 2022 15:32:25 GMT (envelope-from git) Date: Mon, 12 Dec 2022 15:32:25 GMT Message-Id: <202212121532.2BCFWPC4057011@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: 5925cd3e9c3c - main - security/cracklib: fix build with clang 15 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5925cd3e9c3cea926aee6c78aaa1f708665dfa8d Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim (src committer): URL: https://cgit.FreeBSD.org/ports/commit/?id=5925cd3e9c3cea926aee6c78aaa1f708665dfa8d commit 5925cd3e9c3cea926aee6c78aaa1f708665dfa8d Author: Dimitry Andric AuthorDate: 2022-12-12 15:09:19 +0000 Commit: Dimitry Andric CommitDate: 2022-12-12 15:31:26 +0000 security/cracklib: fix build with clang 15 During an exp-run for llvm 15 (see bug 265425), it turned out that security/cracklib failed to build with clang 15: rules.c:346:50: warning: too few arguments in call to 'Debug' Debug(1, "MatchClass: unknown class %c\n", class); ~~~~~ ^ rules.c:346:45: error: incompatible integer to pointer conversion passing 'char' to parameter of type 'char *'; take the address with & [-Wint-conversion] Debug(1, "MatchClass: unknown class %c\n", class); ^~~~~ & This is because cracklib is very old K&R source, and the Debug() function is not defined with varargs, but an arbitrary amount of char pointer arguments. Since the Debug() function does nothing anyway, define it as a varargs macro instead. This also gets rid of most of the other compilation warnings. PR: 268334 Approved by: cy (maintainer) MFH: 2022Q4 --- security/cracklib/files/patch-lib_rules.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/security/cracklib/files/patch-lib_rules.c b/security/cracklib/files/patch-lib_rules.c new file mode 100644 index 000000000000..db39252161ad --- /dev/null +++ b/security/cracklib/files/patch-lib_rules.c @@ -0,0 +1,11 @@ +--- lib/rules.c.orig 2019-02-14 01:54:41 UTC ++++ lib/rules.c +@@ -26,6 +26,8 @@ Debug(val, a, b, c, d, e, f, g) + { + fprintf(stderr, a, b, c, d, e, f, g); + } ++#elif 1 ++#define Debug(n, f, ...) do {} while (0) + #else + static void + Debug(val, a, b, c, d, e, f, g)