Re: git: d5a8c7ca5954 - main - cad/nvc: Correction of the conditional statement
- In reply to: Yuri Victorovich : "git: d5a8c7ca5954 - main - cad/nvc: Correction of the conditional statement"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 11 Dec 2022 23:37:55 UTC
So, now it ended up with:
.include <bsd.port.options.mk>
.if ${ARCH} == "i386" # see the bug#268319 for the LTO failure on i386
CONFIGURE_ARGS+= --disable-lto # workaround for https://github.com/nickg/nvc/issues/579 (undefined symbol: _GLOBAL_OFFSET_TABLE_, see error: undefined symbol: _GLOBAL_OFFSET_TABLE_)
.endif
${OTHER_STUFF}
.include <bsd.port.options.mk>
.if ${ARCH} == powerpc64
CONFIGURE_ARGS+= --enable-lto=no
.endif
Why not use one conditional for both i386 and powerpc64?
Does double inclusion of bsd.port.options.mk even work correctly?
On 22-12-11 19:22:23, Yuri Victorovich wrote:
>The branch main has been updated by yuri:
>
>URL: https://cgit.FreeBSD.org/ports/commit/?id=d5a8c7ca5954840b99c01aff42630441b90ae237
>
>commit d5a8c7ca5954840b99c01aff42630441b90ae237
>Author: Yuri Victorovich <yuri@FreeBSD.org>
>AuthorDate: 2022-12-11 19:21:56 +0000
>Commit: Yuri Victorovich <yuri@FreeBSD.org>
>CommitDate: 2022-12-11 19:21:56 +0000
>
> cad/nvc: Correction of the conditional statement
>---
> cad/nvc/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/cad/nvc/Makefile b/cad/nvc/Makefile
>index 4b8e9d10d601..9404d23dc65b 100644
>--- a/cad/nvc/Makefile
>+++ b/cad/nvc/Makefile
>@@ -34,6 +34,8 @@ GNU_CONFIGURE= yes
> LDFLAGS+= -lexecinfo
>
> CONFIGURE_ARGS= --with-llvm=${LOCALBASE}/bin/llvm-config${LLVM_VERSION}
>+
>+.include <bsd.port.options.mk>
> .if ${ARCH} == "i386" # see the bug#268319 for the LTO failure on i386
> CONFIGURE_ARGS+= --disable-lto # workaround for https://github.com/nickg/nvc/issues/579 (undefined symbol: _GLOBAL_OFFSET_TABLE_, see error: undefined symbol: _GLOBAL_OFFSET_TABLE_)
> .endif