Re: git: 3f78a234e458 - main - graphics/gpu-firmware-kmod: optionize firmware vendors

* Emmanuel Vadot (manu@bidouilliste.com) wrote:

> > The branch main has been updated by amdmi3:
> > 
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=3f78a234e45851fc57d23bd86b6362671244ecc6
> > 
> > commit 3f78a234e45851fc57d23bd86b6362671244ecc6
> > Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
> > AuthorDate: 2022-11-15 20:18:39 +0000
> > Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
> > CommitDate: 2022-11-29 17:18:21 +0000
> > 
> >     graphics/gpu-firmware-kmod: optionize firmware vendors
> >     
> >     PR:             267796
> >     Approved by:    maintainer timeout (x11, 2 weeks)
> > ---
> >  graphics/gpu-firmware-kmod/Makefile | 34 ++++++++++++++++++++++++----------
> >  1 file changed, 24 insertions(+), 10 deletions(-)
> > 
> 
>  Sorry, I've missed this PR.
>  I don't really understand the point of this.
>  This is a meta port that should always build everything, it's mostly
> made for the end package users so every package is available

You don't need to include a package into a metapackage to make it
available )

> and also so
> user who doesn't know which firmware they needs can just pkg install
> this package. If you already know which firmware you need you can just
> pkg install it (or just build it from ports/poudriere).

This is not true because drm-kmod unconditionally pulls
gpu-firmware-kmod which unconditionally pulls all the firmwares.

>  It's a bit unlikely that one user will need only all
> the radeon/amd/intel firmwares.

Well in fact there should be an option for each individual firmware,
but I was lazy. Another valid case is that I have no idea which specific
intel firmware I need, I just don't want nvidia/amd garbage.

-- 
Dmitry Marakasov   .
amdmi3@amdmi3.ru  ..:  https://github.com/AMDmi3  https://amdmi3.ru/