From nobody Wed Aug 10 20:20:45 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M31XY1qP8z4YBHR; Wed, 10 Aug 2022 20:20:45 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M31XY1LJJz3tdY; Wed, 10 Aug 2022 20:20:45 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660162845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hQhT/eSNSAiPCaJ5+yV3xqT8nJUSS6hJIcvVxNzCODY=; b=iEqKh5XgxVLD+V4Uj98orZBzxdNluWJM9albZba1Os1UCTYOl4UDduzoVUV5534I4ztC+7 z+xYw7aHmdUzTz23VLAtcuVQkjoebMVHjMkIkV51U7OhEEOPEEDMrSw9MxN3VyqDPGLdrY Hu5DQSOA9JrWuv7rfRioRoo0eV2yDOwy+MrPgAzZPqUAwkAfi5ZZwMf5GRcONkWfHT2S/q 428eQ4/+7x4kodmBoszmSC92LVOqyJyJYBCVsukl9Bq6CSypGdAm4Fcyz1H3FkkicmJPnI 2EdGjv36Ko7Jq1g5GVdI5TIxUWKwu0/VQNcInpNgzAy+Y2ECq4V/8KbPuzqxIA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 0F03D19F20; Wed, 10 Aug 2022 20:20:45 +0000 (UTC) Date: Wed, 10 Aug 2022 20:20:45 +0000 From: Alexey Dokuchaev To: Larry Rosenman Cc: Larry Rosenman , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: bd12c83965dd - main - net/boinc_curses: adopt, portfmt Message-ID: References: <202208101705.27AH5Ucm054259@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660162845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hQhT/eSNSAiPCaJ5+yV3xqT8nJUSS6hJIcvVxNzCODY=; b=HJcDp51bxQeFiHlXJJFTVX+xUjYKayLurnZH43wVtcqiTLBMpHoW6UXmvFfXwdMSlFzQr8 P7f1mhqtqG5YVd5CVP1BHsci9c0ARiDPGTDSsGneqcMes1ZX5GviVJssiGw8J9W//0VtGk 823+uspy23fRGexcmg6jkmz6bIQhy0CIqSivMMgToLX0Nq8gESAKYyfayy8dWYApbcX1zL BtfeKmfODjf88i1YCywb5Ahergswp2CS9QKmoDCwuYCaCst+53oCLxwvisdzMkqFTKOI9g ceDvFvNlYMweVyWOiCFQFaq2GmbF3mTyxnsMq+1rRYIzHEWOiuOwMM4yTjC+xQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660162845; a=rsa-sha256; cv=none; b=K2Td4nTBevIsy0EzV0Ys11DPH8q+JOsFT5iMYv+yLCFgtAtuKSLTNVd7AVuRKyeo2p6mKL 8o1umUqjpaTqD98zbVzhpwQtDvgF2wOhN+Xtr64zUsvAOmpdPBDIayHnogZRmsostqZKbG a6Jy6n4i8X/mLnIDgwDcnBnr1VZi+L0PqCJS/C8GaON/+MvvNW9Xa4R/s/bXdq6sPcmb9K skcNMDuNy82e3KIBNCp4BgoUBjHtKLsvRKFki4eZmEfgaT+qqvu88SHM0ZiqRekd9ZbP4+ 1cc/QSW/zs9LT63MT5MaqhIKJfQMyRFIYub6VC69TelngA7Qve4NFtuNfMM4Dw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, Aug 10, 2022 at 03:07:37PM -0500, Larry Rosenman wrote: > On 08/10/2022 12:47 pm, Alexey Dokuchaev wrote: > > On Wed, Aug 10, 2022 at 05:41:43PM +0000, Larry Rosenman wrote: > >> From: Alexey Dokuchaev > >> > ... > >> > Just wondering what's the rationale for this change? Previously 'twas > >> > one perfectly readable line which fit the ~80 char terminal width with > >> > some extra slack. We do wrap overly long lines, but why here? > >> > >> Portfmt did it. Not sure [about] rationale. > > > > Looks like a bug in portfmt. FWIW it's just a linting tool, and thus > > its advice should not be followed blindly. > > What major difference does it make? It breaks up short enough line in two for no apparent reason. This is gratuitous change of dubious value which clutters commit diff and makes blaming a bit harder. > the port works, and portfmt makes it somewhat cleaner. I'm not saying that *all* of its suggestions are wrong^Wstrange and/or uncalled for, just this particular one. ./danfe