From nobody Thu Apr 28 06:22:07 2022
X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5E1F21AB28BA;
	Thu, 28 Apr 2022 06:22:07 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4Kplrv2Jb1z4TVC;
	Thu, 28 Apr 2022 06:22:07 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1651126927;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RXedP46A1WmENne2xqzSnwjlgjI6LpK5v9nVVbk3rZY=;
	b=DtlHc7fHtNcYvQNoxTaMv+vHfa7ExljMcEr0bl7z/QIpYIOAGi5Xl4t27D3IJXEL4RLFMH
	8tLI18plyug2undyOI7cu6NzC6+ZRbmpUzIqzTk+nSHVG0XZ7TnE7taqouoeUisO+irEr+
	V03UR40rP7QCutILWrWHAhHqo+3QKq5GPIophHEZ3tXk5BAmYYVVnTOz2kAhnwH1s5OJpO
	rAX1gzsvHkO4QmhUGpMYh8gABPbiiALxkAJyPuBIaHH5vzcjjrQDY+u5zdROaJltMbFl5q
	/XEsn/t+y76Wdpgp32F8op69s4M6rB/aKx3mQUrN0eSUL4Z8CxSyd9aOQ8Dj2A==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
	id 3BDACD22F; Thu, 28 Apr 2022 06:22:07 +0000 (UTC)
Date: Thu, 28 Apr 2022 06:22:07 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Fernando Apestegu??a <fernape@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
	dev-commits-ports-main@freebsd.org
Subject: Re: git: 930715f767cc - main - editors/rehex: update to 0.5.0
Message-ID: <YmoyjyXPRphzGr7P@FreeBSD.org>
References: <202204280601.23S61YQQ010774@gitrepo.freebsd.org>
List-Id: Commits to the main branch of the FreeBSD ports repository <dev-commits-ports-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main
List-Help: <mailto:dev-commits-ports-main+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-main@freebsd.org
X-BeenThere: dev-commits-ports-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202204280601.23S61YQQ010774@gitrepo.freebsd.org>
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1651126927;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RXedP46A1WmENne2xqzSnwjlgjI6LpK5v9nVVbk3rZY=;
	b=TZ9mcfn0bjgHrmZK6scI0rojk+a+YKzixr+6vCJCikEz622OtCrA4FKnYc7jmJC16adwUO
	ORON43r4FAzl5D+NeLMEdoREK2kl+hMPx+RtM+BH67qiJGqE9b4mNZvgr6Sl+rLgx5QfRr
	1SWOAg5GyRNBotrCi08OnmUs67UUxwBITfZezpf843b+otFp4m1m1Vk4AMmOd6WX9Q+1iE
	3J/qs7neAsERJfkjY8sWHv75d7fTMEy8qEQ5cdomVQkzlt/NXsJfnGDYqatKJs9mVmtPoJ
	5P6rt9WimioFYx1FzsrVp00FQfrTKJUh75n13oaCtH8ffoFrA0Uy+nv2Im1sFA==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651126927; a=rsa-sha256; cv=none;
	b=bNa6VuOSFqV8LZzw9AMGsjoOgR7jz3Kqu0iuchzPDwDED5+EQw+lBOA9u0QqA3AyQxD6mU
	pWx2e/78gCMTceuhJ63mkn2JJhC3nZ0REPUcbrGC9LcZZqc88mgI4lDIWixm66rGOTfnm7
	EBVLwCw7Fqf2wCO1KHFuSqmgZ4Pju1JqbXNRguzfGNsqWWYK7WgUactE8XmOk7xY57z9mp
	DLEZ2Spam3SeHUPzftaKlIw1PH/QV5iaZWrZxqAe8xQ4g62DsKrFbQoIl4R1fpHcyVeh8D
	W3gSNJnt38kvww72XaaczT/01V+Q2U/sOPwUI0zCX0BpZel3KDgP0oDMkeWFVg==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-ThisMailContainsUnwantedMimeParts: N

On Thu, Apr 28, 2022 at 06:01:34AM +0000, Fernando Apestegu??a wrote:
> commit 930715f767ccfb6375ee7c56f7ba3134541593de
> 
>   editors/rehex: update to 0.5.0
>     
> -MAKE_ENV=	LUA_PKG="lua-${LUA_VER}" LUA="${LUA_CMD}"
> +MAKE_ENV=	LUA_PKG="lua-${LUA_VER}" LUA="${LUA_CMD}" STRIP="${STRIP}"

So now you have to pass STRIP explicitly...

>  -	install -D -m 0755 $(EXE) $(DESTDIR)$(bindir)/$(EXE)
> -+	$(BSD_INSTALL_PROGRAM) $(EXE) $(DESTDIR)$(bindir)/$(EXE)
> ++	install -m 0755 $(STRIP) $(EXE) $(DESTDIR)$(bindir)/$(EXE)

... to use it here, but BSD_INSTALL_PROGRAM already does it automagically,
why remove it and set the Sun by hands?

> -+		$(BSD_INSTALL_DATA) res/icon$${s}.png $(DESTDIR)$(datarootdir)/icons/hicolor/$${s}x$${s}/apps/rehex.png; \
> ++		install -m 0644 res/icon$${s}.png $(DESTDIR)$(datarootdir)/icons/hicolor/$${s}x$${s}/apps/rehex.png; \

Ditto for BSD_INSTALL_DATA here and below.

./danfe