Re: git: 39df21b6f9be - main - devel/sdl20: mark two options BROKEN when disabled
Date: Fri, 22 Apr 2022 14:31:22 UTC
Dmitry Marakasov wrote:
> * Charlie Li (vishwin@freebsd.org) wrote:
>
>>> The branch main has been updated by amdmi3:
>>>
>>> URL: https://cgit.FreeBSD.org/ports/commit/?id=39df21b6f9becc547762032aab1720edfb6c4fc2
>>>
>>> commit 39df21b6f9becc547762032aab1720edfb6c4fc2
>>> Author: Dmitry Marakasov <amdmi3@FreeBSD.org>
>>> AuthorDate: 2022-04-20 10:54:54 +0000
>>> Commit: Dmitry Marakasov <amdmi3@FreeBSD.org>
>>> CommitDate: 2022-04-20 10:55:07 +0000
>>>
>>> devel/sdl20: mark two options BROKEN when disabled
>>>
>>> Reported by: reprise
>>> ---
>>> devel/sdl20/Makefile | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/devel/sdl20/Makefile b/devel/sdl20/Makefile
>>> index 72f2a1d771b5..751b5df1d444 100644
>>> --- a/devel/sdl20/Makefile
>>> +++ b/devel/sdl20/Makefile
>>> @@ -126,11 +126,13 @@ SDL_ATOMIC_CONFIGURE_ENABLE= atomic gcc-atomics
>>> SDL_AUDIO_CONFIGURE_ENABLE= audio
>>> SDL_CPUINFO_CONFIGURE_ENABLE= cpuinfo
>>> SDL_EVENTS_CONFIGURE_ENABLE= events
>>> +SDL_EVENTS_BROKEN_OFF= does not build: error: use of undeclared identifier 'event_type'
>>> SDL_FILE_CONFIGURE_ENABLE= filesystem
>>> SDL_HAPTIC_CONFIGURE_ENABLE= haptic
>>> SDL_JOYSTICK_CONFIGURE_ENABLE= joystick
>>> SDL_JOYSTICK_BUILD_DEPENDS= ${LOCALBASE}/include/linux/input.h:devel/evdev-proto
>>> SDL_JOYSTICK_LIB_DEPENDS= libinotify.so:devel/libinotify
>>> +SDL_JOYSTICK_BROKEN_OFF= does not build: ld: error: undefined symbol: test_bit
>>> SDL_LOADSO_CONFIGURE_ENABLE= loadso
>>> SDL_POWER_CONFIGURE_ENABLE= power
>>> SDL_RENDER_CONFIGURE_ENABLE= render
>> On what architectures are these broken when disabled? I have JOYSTICK
>> disabled on amd64 and it had always built successfully.
>
> These are unlikely architecture dependent, but I'm testing on amd64
> too. These are reproducible in poudirere, reprise and locally. Also
> the option is named SDL_JOYSTICK.
>
Ran a few more tests (in poudriere) with different OPTION combinations,
seems like only disabling SDL_EVENTS is broken with the specified error.
Not getting the linker error when disabling SDL_JOYSTICK however.
--
Charlie Li
…nope, still don't have an exit line.