From nobody Mon Oct 25 19:38:09 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0B666181DF01; Mon, 25 Oct 2021 19:38:19 +0000 (UTC) (envelope-from tobias.kortkamp@gmail.com) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HdQGy6RKVz4fvl; Mon, 25 Oct 2021 19:38:18 +0000 (UTC) (envelope-from tobias.kortkamp@gmail.com) Received: by mail-ed1-f41.google.com with SMTP id j10so4014538eds.12; Mon, 25 Oct 2021 12:38:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XxLxPaqP8XlgV8BfA/o6Jiv9jSw8D7Ezg8dROIjTEP4=; b=ZbT2CY+49Vc8zPCoDHvrw9ylCC8Tma1ZXV6Gy1GY9gfOXA6IFvDeDZlxpmfasvn1SD oaZTOHtyu6I37KDp6WORXSzT6Xd26cBqACIUVcp196ZH6SH953UXbkFeca5ekHnA7/0s JrzZt6nL7qq5QXLC540MaZUQMZ6xV/8F8MyzCJWNTTyT/Wm46vd6UZyWXyYabvqo8McR ESmubkqOXNuJj8tU/gFugcJFO+nHMPR2kgfOyRn0r5nWStDpN/q6EOTKrbaL9mPkHE2r y8/5VuyHNWlZP7HG8XPzE+oBXn0yBbcLstD/r8phFfEzlbTBReYSUHV6i7zyNW6WuGCn k4/w== X-Gm-Message-State: AOAM533naWUFPN9B7fu7uWuRXcKb6KsMWt7ELwPeKWtwRsq9BhaqGLu9 0NoELeg3OJsLEbwnG/aex5/zATWmus4= X-Google-Smtp-Source: ABdhPJz5IehxUGlIpw73E5sbboHmnurELfFMkhzuvs06M7CdQqsRLGM3nzrsnbeNZgDv2eVaMzey9Q== X-Received: by 2002:a05:6402:42cd:: with SMTP id i13mr28955446edc.396.1635190692059; Mon, 25 Oct 2021 12:38:12 -0700 (PDT) Received: from loki.kortkamp.xyz (p200300e49708a70002155dfffe002610.dip0.t-ipconnect.de. [2003:e4:9708:a700:215:5dff:fe00:2610]) by smtp.gmail.com with ESMTPSA id h10sm9480277edf.85.2021.10.25.12.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 12:38:11 -0700 (PDT) Date: Mon, 25 Oct 2021 21:38:09 +0200 From: Tobias Kortkamp To: "Sergey A. Osokin" Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 15d43d187799 - main - databases/redisjson: Chase USES=cargo's new git source support Message-ID: References: <202110250857.19P8v4v1099045@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4WpGm4THisfBD6wG" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4HdQGy6RKVz4fvl X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --4WpGm4THisfBD6wG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 25, 2021 at 06:37:34PM +0000, Sergey A. Osokin wrote: > Hi Tobias, >=20 > thanks for the update of the port. >=20 > This new approach looks unclear to me, why it's better than GH_TUPLE? > So long line in the CARGO_CRATES list with the branch name, commit > and an escape symbol looks not so convenient to me. >=20 > Does that how the `make cargo-crates` generates CARGO_CRATES from now? - CARGO_CRATES is generated with make cargo-crates as before. Nothing really changes for maintainers. You are not supposed to write those lines manually - The URLs come straight from Cargo.lock as such the URL format is the one that Cargo uses for git sources - Before the first @ is a ,-separated list of all crate names that are inside of the repository - Mapping to G?_TUPLE would loose information (the crate names) which we need later - Also see 2bad8d171afe848ac88585270964342a55d504ce --4WpGm4THisfBD6wG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAmF3B5pfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2FdSgf/cozLDnsNs2VmngdUjhx/w5BK8BXtvaLPHahNPNxZNIhivhA8z4orjgsO 2eCDSHRHFM5vW9eznAex52TkJFsZl4IFynlAlA5AhjkSV5b6Bwa+1kUBe0/LZ9sn S3Ncqqm7lR9l1uhR26gBH9X1byZJwd4EPhnezxI0lAQnzl+PQPwjwIWjdk9A9KgG CUvNA1Vg3XvW7n5zc1By8Hf2Fe6oA0rYSlwMvjdTKjhU5jcT3owmUazjlPP7iaGm l76gFlXl1hiUSkiiwyfCfpTN8vKHrgpJF0cVc7CydAwcQS+4dO8HHzb2X9CdoYgl NF8BlvmmvOc+D8N8IeWnrcOcSluImg== =uNe9 -----END PGP SIGNATURE----- --4WpGm4THisfBD6wG--