Re: git: e59e69659a1f - main - net/dpdk-20.11: add port.

From: Mateusz Piotrowski <0mp_at_FreeBSD.org>
Date: Fri, 15 Oct 2021 06:13:38 UTC
Hi!
On 14/10/2021 09:30, Vanilla I. Shu wrote:
> The branch main has been updated by vanilla:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=e59e69659a1f1f7c2c3f435b889042499a5c5f70
>
> commit e59e69659a1f1f7c2c3f435b889042499a5c5f70
> Author:     Vanilla I. Shu <vanilla@FreeBSD.org>
> AuthorDate: 2021-10-14 07:17:48 +0000
> Commit:     Vanilla I. Shu <vanilla@FreeBSD.org>
> CommitDate: 2021-10-14 07:29:42 +0000
>
>      net/dpdk-20.11: add port.
>      
>      PR:             254402
>      Reported by:    Bruce Richardson <bruce.richardson at intel.com>
> ---

> diff --git a/net/dpdk-20.11/Makefile b/net/dpdk-20.11/Makefile
> new file mode 100644
> index 000000000000..f8d598a1814d
> --- /dev/null
> +++ b/net/dpdk-20.11/Makefile
> @@ -0,0 +1,51 @@
> +# $FreeBSD$
This is not necessary anymore.
> +
> +PORTNAME=	dpdk
> +DISTVERSION=	20.11.1
> +CATEGORIES=	net
> +MASTER_SITES=	http://fast.dpdk.org/rel/
> +PKGNAMESUFFIX=	20.11
Could it be that we wanted to have "-20.11" here instead to match the port origin?
> +
> +MAINTAINER=	bruce.richardson@intel.com
> +COMMENT=	DPDK: Software libraries for packet processing
COMMENT should not contain the name of the software

Also, take a look at the linters available as ports-mgmt/portfmt. They are quite amazing at sorting 
variables in a makefile and formatting it nicely.

Cheers!

Mateusz Piotrowski