Re: git: 2bc3e6229feb - main - net-im/telegram-desktop: Update to 3.1.9

From: Dima Panov <fluffy_at_FreeBSD.org>
Date: Wed, 13 Oct 2021 17:31:16 UTC
Moin!

Have tested the almost same patch.
Small suggestions:

GTK_USE= GNOME=cairo gtk30

GTK_DESC= WebKit-gtk integration

--
Dima. (desktop, kde, x11, office, ports-secteam)@FreeBSD team
(fluffy@FreeBSD.org, https://t.me/dima_panov)

> On Wednesday, Oct 13, 2021 at 8:15 PM, Sergey A. Osokin <osa@freebsd.org (mailto:osa@freebsd.org)> wrote:
> Well, I'm not totally sure is my approach is corrent, but here's the
> patch returning back GTK staff. Please be aware: it wasn't tested yet.
>
> --
> Sergey Osokin
>
> On Tue, Oct 12, 2021 at 02:31:35PM +0000, Alexey Dokuchaev wrote:
> > On Tue, Oct 12, 2021 at 01:57:39PM +0000, Li-Wen Hsu wrote:
> > > commit 2bc3e6229febd07dd7f2980cb7065573d689a0f5
> > >
> > > net-im/telegram-desktop: Update to 3.1.9
> >
> > Thanks for updating the port, however...
> >
> > > ...
> > > @@ -40,6 +39,7 @@ LIB_DEPENDS= libavformat.so:multimedia/ffmpeg \
> > > libpipewire-0.3.so:multimedia/pipewire \
> > > libqrcodegencpp.so:graphics/qr-code-generator \
> > > libusrsctp.so:net/libusrsctp \
> > > + libwebkit2gtk-4.0.so:www/webkit2-gtk3 \
> >
> > Commit log does not explain why would light-weight chat program would now
> > unconditionally depend on this admittedly quite heavy component.
> >
> > > @@ -52,9 +52,10 @@ USE_GITHUB= nodefault
> > > GH_ACCOUNT= telegramdesktop
> > > GH_PROJECT= tdesktop
> > > USE_GL= gl
> > > -USE_GNOME= glib20 glibmm
> > > +USE_GNOME= glib20 glibmm gtk30
> >
> > Nor does it explain why Qt-based program now unconditionally requires GTK.
> >
> > > +INSTALLS_ICONS= yes
> >
> > Please also see the latest CHANGES entry.
> >
> > ./danfe