From nobody Tue Oct 05 16:31:52 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 475FF12D0026; Tue, 5 Oct 2021 16:31:57 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HP35914Nmz3N33; Tue, 5 Oct 2021 16:31:57 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id E2A3625B8; Tue, 5 Oct 2021 16:31:56 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:ab:50:716:1ded:630c:7c39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id C5500942D81; Tue, 5 Oct 2021 16:31:53 +0000 (UTC) Date: Tue, 5 Oct 2021 18:31:52 +0200 From: Mathieu Arnold To: Piotr Kubaj Cc: Mathieu Arnold , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fb5f03a87cf4 - main - Mk/bsd.lto.mk: add global LTO support for ports Message-ID: <20211005163152.gv2vwvg4nuqwga7q@aching.in.mat.cc> References: <202109301834.18UIYKrL013410@gitrepo.freebsd.org> <20211004133056.z7e2iyrhlwprvvvp@aching.in.mat.cc> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="klhpg5nv2ml5b3pw" Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N --klhpg5nv2ml5b3pw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 05, 2021 at 06:27:15PM +0200, Piotr Kubaj wrote: > On 21-10-04 15:30:56, Mathieu Arnold wrote: > > On Thu, Sep 30, 2021 at 06:34:20PM +0000, Piotr Kubaj wrote: > > > The branch main has been updated by pkubaj: > > >=20 > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dfb5f03a87cf432751fae= 1f0ae7f29c9d4fc65917 > > >=20 > > > commit fb5f03a87cf432751fae1f0ae7f29c9d4fc65917 > > > Author: Piotr Kubaj > > > AuthorDate: 2021-09-30 18:27:50 +0000 > > > Commit: Piotr Kubaj > > > CommitDate: 2021-09-30 18:27:50 +0000 > > >=20 > > > Mk/bsd.lto.mk: add global LTO support for ports > > > =20 > > > It's well known that LTO provides both performance and size benef= its for > > > binaries. > > > =20 > > > Add preliminary, opt-in support for global LTO enforcement to por= ts. Ports that > > > provide LTO option on their own and the ones that don't work with= LTO will need > > > to set LTO_UNSAFE in the future. > > > =20 > > > PR: 258536 > >=20 > > Not to be picky about approval and all, but this was added to the > > framework, and the framework is maintained by portmgr. When you want to > > add something to it, you must consult with portmgr before anything gets > > committed. > >=20 > > In that case, we would have told you not to do it this way, but to make > > this a Mk/Uses/lto.mk. > >=20 > > So please, turn this into a USES=3Dlto. >=20 > I did consult, but no one replied. There is absolutely no maintainer timeout for the framework, you cannot just add code there without explicit approval. > IMO adding it to USES is not a good idea, since USES are supposed to be u= sed per port and my idea was to force LTO for all ports, same way that SSP = already does. All I see in the patch is a USE_LTO knob, and a LTO_UNSAFE one, without any documentation of what it is for, what it does, what it might do, what it is about, or anything else. --=20 Mathieu Arnold --klhpg5nv2ml5b3pw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEFD4jMKwz5Ud8Ywu3ecmT/A9inX0FAmFcffdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDE0 M0UyMzMwQUMzM0U1NDc3QzYzMEJCNzc5Qzk5M0ZDMEY2MjlEN0QACgkQecmT/A9i nX3VQAf/an04xpGttKrIOiYVWSkshIQN3sXRNFP//IYBwfjfKMmx9eP+GXNTdO0I W/k+AlhdxS6TZrHE1H1sBBNvQOJmVb+LQYAqTpeiN5CHunU/3Nxsp4pNoGO+sHJp mG+DF1lojBgCgaDFy6gOLL614jBW7UV3/KEEHw7I9Dbj5mk38O4zu/pc6sQzugUC 1h1wJGRuygAyDrHWVVCgxCGtRHYtuBuhoRfK7Hs+GfO/RlmwGQw8v0135xR+Y2Ey ny64OHuHablaYoTCA/6Rprtb8SRJYIrYl+YiOKmkQ5CY3nQsalONeWVEOZ5CAOvv PAL6C/BPb/E7KQTF4ksRXcO+w8vgIQ== =h/Va -----END PGP SIGNATURE----- --klhpg5nv2ml5b3pw--