From nobody Mon Nov 22 06:04:43 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EACE3189A484; Mon, 22 Nov 2021 06:04:53 +0000 (UTC) (envelope-from SRS0=T1ZX=QJ=FreeBSD.org=mfechner@anny.lostinspace.de) Received: from anny.lostinspace.de (anny.lostinspace.de [195.30.95.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4HyGvT5XD6z3Dwv; Mon, 22 Nov 2021 06:04:53 +0000 (UTC) (envelope-from SRS0=T1ZX=QJ=FreeBSD.org=mfechner@anny.lostinspace.de) Received: from server.idefix.lan (192-058-210-188.ip-addr.inexio.net [188.210.58.192]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: idefix@fechner.net) by anny.lostinspace.de (Postfix) with ESMTPSA id 9E30E8F413; Mon, 22 Nov 2021 07:04:44 +0100 (CET) Received: from [IPV6:2a02:6d40:36d8:8001:4d10:7c47:fb29:67ae] (unknown [IPv6:2a02:6d40:36d8:8001:4d10:7c47:fb29:67ae]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by server.idefix.lan (Postfix) with ESMTPSA id 1825775C49F; Mon, 22 Nov 2021 07:04:43 +0100 (CET) Message-ID: <66ec92c6-761f-fd01-fdcc-038b3a1683db@FreeBSD.org> Date: Mon, 22 Nov 2021 07:04:43 +0100 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: git: 46ce086c7130 - main - Mk/Uses: default version for nodejs Content-Language: en-US To: Po-Chuan Hsieh Cc: bradleythughes@fastmail.fm, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202111120555.1AC5tGbw088641@gitrepo.freebsd.org> From: Matthias Fechner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: anny.lostinspace.de X-Rspamd-Queue-Id: 4HyGvT5XD6z3Dwv X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N Am 21.11.2021 um 22:18 schrieb Po-Chuan Hsieh: > > Don't get me wrong. > Adding USES=nodejs is one thing. Changing the default nodejs is > another thing. > We need more work before changing the default. > For example, it is really weird to have 4 npm ports, www/npm and > www/npm-node{14,16,17}, now. > > My point is, you did this just because gitlab does not support node 17. > Even so, you should always find a less aggressive way to fix things. > Your first trial did break rubygem-rails60. > Your second trial which is unnecessary just affects lots of ports. > And it is not accepted/approved. > > Here's the patch [1] which does not have www/node in gitlab's > dependencies. > I'll commit it later. > > [1] https://people.FreeBSD.org/~sunpoet/patch/node.txt > I don't get you wrong, but I do not understand why you would like to roll back something, where we received no bug report. To clean up the ports can be done, but I do not understand why you enforce the user, that they must use an unstable development version of node. Having now [npm,yarn]{-14,-16-17} will allow the full flexibility for the users to install whatever combination they like, without compiling anything (just use pkg). I'm very sure that this commit even fixed most of the problems for most users. Rolling back node to unstable development version will break node again for some users (it really depends what npm dependencies you use, but many of them are marked to be broken with node17). I think that Bradley should comment on this and I'm sure, if he has time again, he will. We emailed in private and told me that he wanted to have that done this already for years, but did not have time for this. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook