From nobody Thu Nov 18 01:59:08 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AC37518552EF; Thu, 18 Nov 2021 01:59:08 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hvjdm4RXWz52Dl; Thu, 18 Nov 2021 01:59:08 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637200748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I3TluwAXAjfhGhgMKjAITmcLKfPOccqYYRshd2qX7v8=; b=laaH+/1R9KMEpZwnWel47dN5K5cfz2HyKKuQZbyFTf37r3nJqA1fy3RlgL8fRxUbPhv1+W B4gui6LflZPH+HCqHf6h1/i8/+DUxj6jfli821JSfiIronHvRZOaf+7Zqp8kZecbQhEWVs KH6Xhd6ZKaPddq56S8sEf8nNsAXZR+q0E3tnhotJpm72TqjkRXYDNsbTnBUO8Ou1LpJTiN SL86W6ZRkGu9VbyRKMpnTLUQ6QlRe9P17K12NwI23rQvlXF1gfZtwj9EoLsbZCnJVy/8F2 2ouNRSELZYxdD10v/FHdDzwb4ujSaB1wOnvZ8mpR/K+8rq7Md630Y6s2oA9Jaw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 81AEC910A; Thu, 18 Nov 2021 01:59:08 +0000 (UTC) Date: Thu, 18 Nov 2021 01:59:08 +0000 From: Alexey Dokuchaev To: Olivier Cochard Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 50119a0b4317 - main - net-im/telegram-desktop: Cleanup and set new maintainer Message-ID: References: <202111171708.1AHH81SP093799@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202111171708.1AHH81SP093799@gitrepo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637200748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I3TluwAXAjfhGhgMKjAITmcLKfPOccqYYRshd2qX7v8=; b=uun9PqhVihnnubs/hBdjrREmdxppb9+4DO+Vubrt5GUM62ipulUTzOyyR+geB/68ZHIcVT tQQoRxbJlR7w0BCEZITZb7Po/QEKdRxmlmxxZEvhN62tmrpEv9M4ske095VYP1Z4depLha /GicKJxozhpkWQzo5FpJdFTgltL2vww0aO+PfiyY8+ryt0Zle25gf6/IfjgJqluSdWC58D OLBSW4/gvEY4GsAlp8b7LeFFA0CmwC86oAfIZxy5QXbScCAdpZx7m33PURPyjMZQf6aXTk P+6N3r3SWOBJTpoaArz0ZuvWt909k7ITbcE+nl0oiNfs9DQFysV1p7lWjGzvzA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637200748; a=rsa-sha256; cv=none; b=WVx/GVDMy6lm/JqIjTrIZ0CguvjLAA/RUo4cTo+/euMxuA2mRWynw5BLo3ecI5Zao0LO7p WbEnwjQOee0FaGXIlDotGK21AFS75WW7KJcOlz0tDkgOVmgH7A4tBN5hxwkyChZcmjczmP Ps8Mkk130N2ll9x7UEYlTaxhjBZUW/9OolY1+Z1RG67gNmsY0cHJ8mtimnj1oHbKOR8x6Z 0DL6kBtkLmRBq/wGMOPdHiReWdJxpG8LfjAMMw/K8Eyfdfxj4ZoEQZELMIxAXy+rcnm0v2 X0W8C2fnHn0O06UPPAubBzmeYmJILrfwd/B/JJ8Bb0tvrwNnhLf40YFHdxI6Bw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, Nov 17, 2021 at 05:08:01PM +0000, Olivier Cochard wrote: > commit 50119a0b431718d00a22f424a550239246021ff9 > > net-im/telegram-desktop: Cleanup and set new maintainer > > Reported by: glebius Sorry, I don't understand, what exactly was "reported" here? This looks more like a patch submission committed without maintainer approval. > -CMAKE_OFF= DESKTOP_APP_USE_PACKAGED_RLOTTIE DESKTOP_APP_USE_PACKAGED_VARIANT \ > - DESKTOP_APP_USE_GLIBC_WRAPS TDESKTOP_USE_PACKAGED_TGVOIP \ > - DESKTOP_APP_USE_PACKAGED_FONTS > +CMAKE_OFF= DESKTOP_APP_USE_PACKAGED_FONTS These vars being dropped from CMAKE_OFF should've been explained. > +INSTALLS_ICONS= yes > + Please see the latest CHANGES entry 20211010. > -.if ${CHOSEN_COMPILER_TYPE} == clang && ${COMPILER_VERSION} <= 100 > -post-patch: > - @${REINPLACE_CMD} -e '/-fstack-clash-protection/d' ${WRKSRC}/cmake/options_linux.cmake > +.if ${COMPILER_VERSION} < 120 > +LLVM_VER= 12 > +BUILD_DEPENDS+= clang${LLVM_VER}:devel/llvm${LLVM_VER} > +CC= ${LOCALBASE}/bin/clang${LLVM_VER} > +CXX= ${LOCALBASE}/bin/clang++${LLVM_VER} Pulling in non-default LLVM port is hardly a "cleanup" and also deserves a proper explanation; so does removing those patches. ./danfe