From nobody Wed Nov 10 11:18:07 2021
X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0773E184F2A0;
	Wed, 10 Nov 2021 11:18:10 +0000 (UTC)
	(envelope-from bapt@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4Hq2QT6XXxz3ndl;
	Wed, 10 Nov 2021 11:18:09 +0000 (UTC)
	(envelope-from bapt@FreeBSD.org)
Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client did not present a certificate)
	(Authenticated sender: bapt)
	by smtp.freebsd.org (Postfix) with ESMTPSA id A88062F95E;
	Wed, 10 Nov 2021 11:18:09 +0000 (UTC)
	(envelope-from bapt@FreeBSD.org)
Received: by aniel.nours.eu (Postfix, from userid 1001)
	id 81C59821F1; Wed, 10 Nov 2021 12:18:07 +0100 (CET)
Date: Wed, 10 Nov 2021 12:18:07 +0100
From: Baptiste Daroussin <bapt@FreeBSD.org>
To: Jan Beich <jbeich@FreeBSD.org>
Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org,
	dev-commits-ports-main@FreeBSD.org
Subject: Re: git: b68bef1f6425 - main - x11-wm/kwinft: unbreak build after
 5d998836b36f
Message-ID: <20211110111807.godb2dxxsdjlv7wk@aniel.nours.eu>
References: <202111101058.1AAAwkpv046598@gitrepo.freebsd.org>
List-Id: Commits to the main branch of the FreeBSD ports repository <dev-commits-ports-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main
List-Help: <mailto:dev-commits-ports-main+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-main@freebsd.org
X-BeenThere: dev-commits-ports-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202111101058.1AAAwkpv046598@gitrepo.freebsd.org>
X-ThisMailContainsUnwantedMimeParts: N

On Wed, Nov 10, 2021 at 10:58:46AM +0000, Jan Beich wrote:
> The branch main has been updated by jbeich:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=b68bef1f6425117cd0d0d95626178db4c4fb3073
> 
> commit b68bef1f6425117cd0d0d95626178db4c4fb3073
> Author:     Jan Beich <jbeich@FreeBSD.org>
> AuthorDate: 2021-11-10 09:24:08 +0000
> Commit:     Jan Beich <jbeich@FreeBSD.org>
> CommitDate: 2021-11-10 10:58:09 +0000
> 
>     x11-wm/kwinft: unbreak build after 5d998836b36f
>     
>     input/filters/window_selector.cpp:19:10: fatal error: 'linux/input.h' file not found
>      #include <linux/input.h>
>               ^~~~~~~~~~~~~~~
>     
>     Pointy hat to:  manu

To be honnest I am puzzled about this pointy hat, while manu should have tested the
reverse dependencies of mtdev to make sure noone wrongly took its run
dependencies as granted as its own build dependencies and fix them upfront,
On the otherside, all the ports should be explicit about ALL their direct build
dependencies, and not expect another port to provide them. 

Meaning the said ports were buggy in the first place.

This is one of the reason the Pointy hat culture has been removed from the ports
land in general in favor or at best only accepting self pointy hatting.

So as a community if we could avoid finger pointing at others.

Best regards,
Bapt