Re: git: d356121270d7 - main - mail/postfix{,-ldap-sasl,-sasl}: Flavorize

Hi,


> On 1 Nov 2021, at 19:44, Tobias Kortkamp <tobik@FreeBSD.org> wrote:
> 
> On Thu, Oct 28, 2021 at 12:07:22AM +0000, Yasuhiro Kimura wrote:
>> -POSTFIX_CCARGS+=	-DDEF_CONFIG_DIR=\\\"${ETCDIR}\\\" \
>> -			-DDEF_DAEMON_DIR=\\\"${DAEMONDIR}\\\" \
>> -			-DDEF_META_DIR=\\\"${META_DIRECTORY}\\\" \
>> -			-DDEF_COMMAND_DIR=\\\"${PREFIX}/sbin\\\" \
>> -			-DDEF_SENDMAIL_PATH=\\\"${PREFIX}/sbin/sendmail\\\" \
>> -			-DDEF_NEWALIAS_PATH=\\\"${PREFIX}/bin/newaliases\\\" \
>> -			-DDEF_MAILQ_PATH=\\\"${PREFIX}/bin/mailq\\\" \
>> -			-DDEF_MANPAGE_DIR=\\\"${MANPREFIX}/man\\\" \
>> -			-DDEF_README_DIR=\\\"${READMEDIR}\\\" \
>> -			-DDEF_HTML_DIR=\\\"${READMEDIR}\\\" \
>> -			-DDEF_QUEUE_DIR=\\\"/var/spool/postfix\\\" \
>> -			-DDEF_DATA_DIR=\\\"/var/db/postfix\\\" \
>> -			-DDEF_MAIL_OWNER=\\\"postfix\\\" \
>> -			-DDEF_SGID_GROUP=\\\"maildrop\\\" \
>> -			-Wmissing-prototypes -Wformat -Wno-comment
>> +POSTFIX_CCARGS+=	-DDEF_CONFIG_DIR=\\\"${ETCDIR}\\\" -DDEF_DAEMON_DIR=\\\"${DAEMONDIR}\\\" -DDEF_META_DIR=\\\"${META_DIRECTORY}\\\" -DDEF_COMMAND_DIR=\\\"${PREFIX}/sbin\\\" -DDEF_SENDMAIL_PATH=\\\"${PREFIX}/sbin/sendmail\\\" -DDEF_NEWALIAS_PATH=\\\"${PREFIX}/bin/newaliases\\\" -DDEF_MAILQ_PATH=\\\"${PREFIX}/bin/mailq\\\" -DDEF_MANPAGE_DIR=\\\"${MANPREFIX}/man\\\" -DDEF_README_DIR=\\\"${READMEDIR}\\\" -DDEF_HTML_DIR=\\\"${READMEDIR}\\\" -DDEF_QUEUE_DIR=\\\"/var/spool/postfix\\\" -DDEF_DATA_DIR=\\\"/var/db/postfix\\\" -DDEF_MAIL_OWNER=\\\"postfix\\\" -DDEF_SGID_GROUP=\\\"maildrop\\\" -Wmissing-prototypes -Wformat -Wno-comment
> 
> Hi,
> 
> this is caused by a tokenizer bug in portfmt where it treated
> the entire thing as one word. It is not ok for portfmt to format
> POSTFIX_CCARGS like that. I fixed it in [0].
> 
> Sorry, I saw it in the review earlier but forgot to comment on
> it. Please report stuff like this to me on GitHub [1] or on
> Bugzilla.
> 


I will commit a better readable Makefile without any functional changes.

Thanks anyway for portfmt update :-)

otis

—
Juraj Lutter
otis@FreeBSD.org