From nobody Mon Nov 01 17:37:03 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id BA4AE1821FA6; Mon, 1 Nov 2021 17:38:25 +0000 (UTC) (envelope-from yasu@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HjgHP4z63z4g3k; Mon, 1 Nov 2021 17:38:25 +0000 (UTC) (envelope-from yasu@FreeBSD.org) Received: from localhost (gate.home.utahime.org [183.180.29.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: yasu/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 74C4E29335; Mon, 1 Nov 2021 17:38:24 +0000 (UTC) (envelope-from yasu@FreeBSD.org) Date: Tue, 02 Nov 2021 02:37:03 +0900 (JST) Message-Id: <20211102.023703.1883557663869848680.yasu@FreeBSD.org> To: garga@FreeBSD.org Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 67be9a912d61 - main - devel/git: Update to 2.33.1 From: Yasuhiro Kimura In-Reply-To: <1e6ee54f-7917-49dc-ae65-44d4f5e71291@FreeBSD.org> References: <202110300623.19U6NOPO023944@gitrepo.freebsd.org> <1e6ee54f-7917-49dc-ae65-44d4f5e71291@FreeBSD.org> X-Mailer: Mew version 6.8 on Emacs 29.0.50 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N Hello Renato. From: Renato Botelho Subject: Re: git: 67be9a912d61 - main - devel/git: Update to 2.33.1 Date: Mon, 1 Nov 2021 11:55:24 -0300 > Yasuhiro, > > Thanks for pushing the upgrade. One small note, when HTMLDOCS option > is set, it installs a small txt file with notes for each version. The > patch you pushed is missing one pkg-plist entry for that: > > %%HTMLDOCS%%%%DOCSDIR%%/RelNotes/2.33.1.txt Thank you for reporting it. And sorry for breackage. I pushed the fix. But at the same time another problem is found. Before submitting update to 2.33.1, I did poudriere build test with HTMLDOCS is ON. And poudriere didn't report any error at check-plist stage. So I removed all lines starting with '%%HTMLDOCS%%' from pkg-plist and did test build again. Then check-plist didn't report any error either. That is, `make check-plist` doesn't report any plist error about files installed when HTMLDOCS is enabled. It doesn't happen with other options. For example if I removes line starting with '%%CURL%%', then `make check-plist` detects plist error successfully. Though I'm not sure exactly when, I remember plist error related to HTMLDOCS option was successfully detected when I created patch to updated the port previously. So it's very strange that only plist error related to HTMLDOCS become undetected. --- Yasuhiro Kimura