From nobody Mon Dec 13 20:46:16 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EFE5318E944E; Mon, 13 Dec 2021 20:46:19 +0000 (UTC) (envelope-from driesm@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JCYSq5rxVz3QPc; Mon, 13 Dec 2021 20:46:19 +0000 (UTC) (envelope-from driesm@freebsd.org) Received: from [IPV6:2a02:1811:251a:d241:faac:65ff:fee1:267a] (ptr-8slu6ici5za0g1aldoa.18120a2.ip6.access.telenet.be [IPv6:2a02:1811:251a:d241:faac:65ff:fee1:267a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: driesm) by smtp.freebsd.org (Postfix) with ESMTPSA id 3406929BC7; Mon, 13 Dec 2021 20:46:19 +0000 (UTC) (envelope-from driesm@freebsd.org) Message-ID: Date: Mon, 13 Dec 2021 21:46:16 +0100 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: git: 074939ea0793 - main - security/i2pd: Update to 2.40.0 Content-Language: en-US To: Eugene Grosbein , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202112131754.1BDHscmg063776@gitrepo.freebsd.org> From: Dries Michiels In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639428379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y2oNsVwvTT8qZrW9q53IvIfJv/UhuVLEAYhXCidfcSg=; b=AEnSdJYZABQ0YCqpQ0twxauZDnbNqJez5NJMbfm+4d0BD+nemr+OeITTMeXhUauajehwiO DN5y3aB3Q/CHK/EzR/W5K0uyEWnCbF/tcznIhLlOow5RqoB134eer/aCZq4ZNYgT2a/uPC Um0BW/qZwWQ+mXxbdZpENHM4GDw8vbZhnHgoqKatFYqyBVXGj9eWDfpQ+9LjjAg5kQEfcZ I75/SXeVrtUD9fegSE0G0s2bAo8WIPFXcYcZuDqx88jPFJld+vKon0jSl/WcWZuWV95g4Y XuR8oYUmtTrlcacrkckoxXcSiIHRIEZrauY/+fViA/UxymvllUpet/Av6L1DLA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639428379; a=rsa-sha256; cv=none; b=qJivkOPSVQSm1tyAHb5Gs+7UmKUXzAgZ7LP0VeDG0V/OSa6h/oKbPh9oWJndYfg8BXsF09 OVAxL33MI4vGprLUYCws6wvOqQE2ajCzYgdWIz0MSOWHng0YLfSrGMeEqIh3UPyvQFXisk FmUFX1GjySb/BRL9uGQX8VgyIf1K2MRNqQ7QYF9E/UWS/5TwRPxhi+5Mg6SwI7j6SBPptk /n1iAGxzkD0WK6gzQJYgs53u4neJotuL9iKZvtqK4ZyhNsNSKUZ6F6r1ODVz+3JD9n+S2v OpLivTgrDeEXgJ8+7N3jdnB6nhvkeqj+SNv10tdT+2lc0kS7JBUwLjUBdPCDaQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 12/13/21 20:47, Eugene Grosbein wrote: > 14.12.2021 0:54, Dries Michiels wrote: > >> post-install: >> ${INSTALL_MAN} ${WRKSRC}/debian/${PORTNAME}.1 ${STAGEDIR}${MAN1PREFIX}/man/man1 >> @${MKDIR} ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d >> - ${INSTALL_DATA} ${WRKDIR}/i2pd.newsyslog.conf ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d/i2pd.conf >> + ${INSTALL_DATA} ${WRKDIR}/i2pd.newsyslog.conf ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d/i2pd.conf.sample > This presents a regression for users upgrading from previous versions that did not change newsyslog.conf.d/i2pd.conf > and relied on defaults for log rotation. Now they end up without rotation unless catch up with the change, don't they? That is not true, as the sample is tagged as @sample in pkg-plist. It will just copy the .sample to the .conf file if you didn't touch it. If you did, your current config is kept. > What is a benefit of NOT installing rotation by default? It is installed, through the @sample macro in pkg-plist. Dries