From nobody Mon Dec 13 19:47:37 2021
X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 94DCF18DD8AF;
	Mon, 13 Dec 2021 19:47:49 +0000 (UTC)
	(envelope-from eugen@grosbein.net)
Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4JCX9K1Ghcz3Gkh;
	Mon, 13 Dec 2021 19:47:48 +0000 (UTC)
	(envelope-from eugen@grosbein.net)
Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged))
	by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id 1BDJljCM083385
	(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Mon, 13 Dec 2021 19:47:46 GMT
	(envelope-from eugen@grosbein.net)
X-Envelope-From: eugen@grosbein.net
X-Envelope-To: driesm@FreeBSD.org
Received: from [10.58.0.10] (dadvw [10.58.0.10])
	by eg.sd.rdtc.ru (8.16.1/8.16.1) with ESMTPS id 1BDJli7w063986
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT);
	Tue, 14 Dec 2021 02:47:44 +0700 (+07)
	(envelope-from eugen@grosbein.net)
Subject: Re: git: 074939ea0793 - main - security/i2pd: Update to 2.40.0
To: Dries Michiels <driesm@FreeBSD.org>, ports-committers@FreeBSD.org,
        dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
References: <202112131754.1BDHscmg063776@gitrepo.freebsd.org>
From: Eugene Grosbein <eugen@grosbein.net>
Message-ID: <fd37edb8-f819-ddb6-cf33-99ca0cc6a845@grosbein.net>
Date: Tue, 14 Dec 2021 02:47:37 +0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
List-Id: Commits to the main branch of the FreeBSD ports repository <dev-commits-ports-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main
List-Help: <mailto:dev-commits-ports-main+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-main@freebsd.org
X-BeenThere: dev-commits-ports-main@freebsd.org
MIME-Version: 1.0
In-Reply-To: <202112131754.1BDHscmg063776@gitrepo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT
	autolearn=disabled version=3.4.2
X-Spam-Report: 
	* -0.0 SHORTCIRCUIT No description available.
	* -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net
X-Rspamd-Queue-Id: 4JCX9K1Ghcz3Gkh
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-Spam: Yes
X-ThisMailContainsUnwantedMimeParts: N

14.12.2021 0:54, Dries Michiels wrote:

>  post-install:
>  	${INSTALL_MAN} ${WRKSRC}/debian/${PORTNAME}.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
>  	@${MKDIR} ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d
> -	${INSTALL_DATA} ${WRKDIR}/i2pd.newsyslog.conf ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d/i2pd.conf
> +	${INSTALL_DATA} ${WRKDIR}/i2pd.newsyslog.conf ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d/i2pd.conf.sample

This presents a regression for users upgrading from previous versions that did not change newsyslog.conf.d/i2pd.conf
and relied on defaults for log rotation. Now they end up without rotation unless catch up with the change, don't they?

What is a benefit of NOT installing rotation by default?