Re: git: b8c4bfe660b3 - main - sysutils/reptyr: Address LLVM 13 build failure

From: Kubilay Kocak <koobs_at_FreeBSD.org>
Date: Thu, 02 Dec 2021 01:05:46 UTC 
On 2/12/2021 11:54 am, Cy Schubert wrote:
> The branch main has been updated by cy:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=b8c4bfe660b373862165a58514f270a51e77e147
> 
> commit b8c4bfe660b373862165a58514f270a51e77e147
> Author:     Cy Schubert <cy@FreeBSD.org>
> AuthorDate: 2021-12-02 00:47:57 +0000
> Commit:     Cy Schubert <cy@FreeBSD.org>
> CommitDate: 2021-12-02 00:54:18 +0000
> 
>      sysutils/reptyr: Address LLVM 13 build failure
>      
>      Rather than create a patch, simply add -Wno-unused-but-set-variable,
>      avoiding a maintainer to backport patches any time the port is updated.
>      
>      In file included from platform/freebsd/freebsd_ptrace.c:69:
>      In file included from platform/freebsd/arch/amd64.h:23:
>      platform/freebsd/arch/x86_common.h:45:6: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
>              int ret;
>                  ^
>      platform/freebsd/arch/x86_common.h:54:6: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
>              int ret;
>                  ^
>      2 errors generated.

Ports usually shouldn't use -Werror and people are strongly encouraged 
to add -Wno-error or patch it out is the usual course of action, but 
sure, specific warnings can be scoped too.

>      
>      MFH after:      3 days
> ---
>   sysutils/reptyr/Makefile | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sysutils/reptyr/Makefile b/sysutils/reptyr/Makefile
> index 548a66b196f1..a4895b1d59dc 100644
> --- a/sysutils/reptyr/Makefile
> +++ b/sysutils/reptyr/Makefile
> @@ -15,6 +15,7 @@ GH_ACCOUNT=	nelhage
>   
>   MAKE_ARGS=	BASHCOMPDIR=${PREFIX}/share/bash-completion/completions \
>   		MANDIR=${MANPREFIX}/man
> +CFLAGS+=	-Wno-unused-but-set-variable
>   USES=		gmake
>   
>   ONLY_FOR_ARCHS=	i386 amd64