From nobody Sat Feb 24 11:06:17 2024 X-Original-To: dev-commits-ports-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ThkZx3sg1z5CYDL; Sat, 24 Feb 2024 11:06:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ThkZx3RFSz4gZh; Sat, 24 Feb 2024 11:06:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708772777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ikaohD9kTVFAdKNyIOgKsg/6jLOws/Rwf2omV+m/lu8=; b=iVpowQRN3tb2vA1fuKWYkV8TuzctafsKwbos4EEF5Vj5awj3nv3pNWGGhjKf2ZQQkXREiM jUM3w0RJ2H97o1tUmFFy9meR0Ipi595B1Wkq/Ur7nBFfGqULNnNesyK/zCYqCABl+oWfJY AKPlpaVexKfc3RuXoRH8JrqJxUvgikJZ6yc4HIAsVBbEBQWp60qEQZVrxlxzpYy/JDkYNl G1NGKAUKBo8x/tzSC4orci/SeNs1T83spvLsF0yEan593doN8Zqc8E5CL2ZQtvEHVNWeYI V3vmGaPCqUc4XCQFFJd++JAK44xaJLoeJKwpchTDq6OomT5ZgKOi3g7zj0e2KA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708772777; a=rsa-sha256; cv=none; b=hrCY8d87/xRBTgAgAhCzr6oAtD19i1GgbPx3HL3jV5qKgfOlB/D43gT1zXA2TdtxJIIpib DE6ADC7vZDGn7Iz/1bQFD3QXXKlJaRTT5wCra5N9mL8OfEf8hhvCRUXNNaVSs8bTqc9HdI Xy9pNiNJQsEvZSJE3RUlclFv+OhYKMy6EfzuZNLaMgf3qPY6ceuUw78Buq5eE8Y2soadVy g779+DD4jxkyq0ClKCDiYg/Pjl6THMQUKa0c6IpBvCkDIrHYmRNQ5cfPCUQ+QDIUMwTZ1S XJ0nC0ikhdPfgHSQ0Id87bUFhPy62hjt7kXn0Zl5gnzcMlE95hsKUANHh0Zl3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708772777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ikaohD9kTVFAdKNyIOgKsg/6jLOws/Rwf2omV+m/lu8=; b=n6pdyYKP2jQDpxk5rpudnKtXWV0pXBXyUdjzujAu24DxjQemMtKpmF/7qD/uWUEjnEkItX pPKplEnCxqpJ4fFTwG6hY1jzRGMeMdI2sDSFjVXo7UCjgM7knNn9q52EcEI0FMOoixkAfx 1HkylxtA0BM0adSlznK9dHnIRmmlNCCujGHieIP0eIo7OUiDRA+I2VN8mR24IBR2lnkdNX +VsNAqm7cbkkIQlINcBZgq5d2mrTAQBVnc2IOt6mK27f9lDGbbeTUsOg8yxTLQyidtDj5p q1fPv8ereSZsEMKITjDBfXqWr1ewLgKo6R/b3UJyp+XWN9ex0JVYzaSGk5WUmw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ThkZx2VmJzwtF; Sat, 24 Feb 2024 11:06:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41OB6HJx066131; Sat, 24 Feb 2024 11:06:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41OB6HoH066128; Sat, 24 Feb 2024 11:06:17 GMT (envelope-from git) Date: Sat, 24 Feb 2024 11:06:17 GMT Message-Id: <202402241106.41OB6HoH066128@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org From: Dimitry Andric Subject: git: 9c744e2660ed - 2024Q1 - devel/bossa: fix build with clang 18 List-Id: Commits to the quarterly branches of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-branches@freebsd.org X-BeenThere: dev-commits-ports-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/2024Q1 X-Git-Reftype: branch X-Git-Commit: 9c744e2660ed1445a4b8453ec3fcdeba11e28f5a Auto-Submitted: auto-generated The branch 2024Q1 has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=9c744e2660ed1445a4b8453ec3fcdeba11e28f5a commit 9c744e2660ed1445a4b8453ec3fcdeba11e28f5a Author: Dimitry Andric AuthorDate: 2024-02-03 13:21:20 +0000 Commit: Dimitry Andric CommitDate: 2024-02-24 11:06:04 +0000 devel/bossa: fix build with clang 18 Clang 18 has a new warning about variable length arrays used in C++, which is emitted when building devel/bossa: src/Flasher.cpp:115:28: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension] 115 | uint8_t buffer[bufferSize]; | ^~~~~~~~~~ src/Flasher.cpp:115:28: note: read of non-const variable 'bufferSize' is not allowed in a constant expression src/Flasher.cpp:114:22: note: declared here 114 | uint32_t bufferSize = _samba.writeBufferSize(); | ^ [... more of these ...] Since refactoring the code to no longer use VLAs is rather intrusive, suppress the warnings instead. While here, pet portlint. PR: 276804 Approved by: maintainer timeout (2 weeks) MFH: 2024Q1 (cherry picked from commit 30a231f8eb872f67eac8514ba96da91cc4b9f44f) --- devel/bossa/Makefile | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/devel/bossa/Makefile b/devel/bossa/Makefile index ddffddb09b6c..9d0e48e37107 100644 --- a/devel/bossa/Makefile +++ b/devel/bossa/Makefile @@ -1,5 +1,6 @@ PORTNAME= bossa PORTVERSION= 1.9.1 +PORTREVISION= 1 CATEGORIES= devel MAINTAINER= kevans@FreeBSD.org @@ -9,12 +10,12 @@ WWW= https://github.com/shumatech/BOSSA LICENSE= BSD3CLAUSE LICENSE_FILE= ${WRKSRC}/LICENSE +USES= compiler:c++11-lang gmake + USE_GITHUB= yes GH_ACCOUNT= shumatech GH_PROJECT= ${PORTNAME:tu} -USES= compiler:c++11-lang gmake - CXXFLAGS+= -I${PREFIX}/include LDFLAGS+= -L${PREFIX}/lib @@ -32,6 +33,12 @@ BOSSASH_DESC= Include BOSSA Shell BOSSASH_USES= readline BOSSASH_ALL_TARGET= bin/bossash +.include + +.if ${COMPILER_TYPE} == clang && ${COMPILER_VERSION} >= 180 +CXXFLAGS+= -Wno-vla-cxx-extension +.endif + post-extract: ${REINPLACE_CMD} -e 's/wx-config/$${WX_CONFIG}/' ${WRKSRC}/Makefile @@ -44,4 +51,4 @@ do-install-BOSSA-on: do-install-BOSSASH-on: ${INSTALL_PROGRAM} ${WRKSRC}/bin/bossash ${STAGEDIR}${PREFIX}/bin/bossash -.include +.include