git: d90d859fe8ae - 2024Q4 - security/heimdal-devel: fix with stock clang and lld >= 16

The branch 2024Q4 has been updated by dim:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d90d859fe8ae470f14e8326c4e8eaae224bb3ca6

commit d90d859fe8ae470f14e8326c4e8eaae224bb3ca6
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-12-04 18:53:13 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-12-04 19:47:29 +0000

    security/heimdal-devel: fix with stock clang and lld >= 16
    
    Upstream clang >= 16 made -Wimplicit-function-declaration into an error
    by default. In the base system, this change was reverted to reduce the
    fallout in ports, because there are many problematic configure scripts.
    
    For security/heimdal-devel this also applies, so for building the port
    with devel/llvm16 or higher we need to add
    -Wno-implicit-function-declaration to CFLAGS.
    
    Additionally, similar to bug 275979, add -Wl,--undefined-version to
    LDFLAGS, to suppress any linker errors about missing versioned symbols.
    
    PR:             283132
    Approved by:    cy (maintainer)
    MFH:            2024Q4
    
    (cherry picked from commit c1d61be19caf5dd7c4dee1fc0f60c76d8aab3b64)
---
 security/heimdal-devel/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/security/heimdal-devel/Makefile b/security/heimdal-devel/Makefile
index a26934b6a4f5..ddb12f00825e 100644
--- a/security/heimdal-devel/Makefile
+++ b/security/heimdal-devel/Makefile
@@ -57,6 +57,8 @@ CONFIGURE_ARGS=	--with-berkeley-db \
 # XXX --with-readline picks up libreadline even if found in /usr/lib.
 GNU_CONFIGURE_MANPREFIX= ${PREFIX}/share
 MAKE_ENV=	INSTALL_CATPAGES=no
+CFLAGS+=	-Wno-implicit-function-declaration
+LDFLAGS+=	-Wl,--undefined-version
 INSTALL_TARGET=	install-strip
 .if !exists(/etc/rc.d/ipropd_master)
 USE_RC_SUBR=	ipropd_master ipropd_slave