git: 50cdf3908631 - 2024Q3 - java/openjdk17: fix build with clang 19

The branch 2024Q3 has been updated by dim:

URL: https://cgit.FreeBSD.org/ports/commit/?id=50cdf3908631cd59cf470624850f5f4bb5bed5a2

commit 50cdf3908631cd59cf470624850f5f4bb5bed5a2
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-01 16:05:22 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-07 16:51:46 +0000

    java/openjdk17: fix build with clang 19
    
    Clang 19 has a number of new warnings, and because java/openjdk17
    compiles with -Werror by default, it results in errors similar to:
    
        /wrkdirs/usr/ports/java/openjdk17/work/jdk17u-jdk-17.0.12-7-1/src/hotspot/os/posix/signals_posix.cpp:1681:20: error: cast from 'void (*)(int, siginfo_t *, ucontext_t *)' (aka 'void (*)(int, __siginfo *, __ucontext *)') to 'void (*)(int)' converts to incompatible function type [-Werror,-Wcast-function-type-mismatch]
         1681 |   act.sa_handler = (void (*)(int)) SR_handler;
              |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
    
    I propose to disable warnings-as-errors for this port, similar to what
    is already done for openjdk8 and openjdk11. It does not make sense to
    have this on by default, unless you are an upstream maintainer.
    
    PR:             280561
    Approved by:    glewis (maintainer)
    MFH:            2024Q3
    
    (cherry picked from commit 4c37f9f5f253a5701fa94ddfc00520889bca9ea4)
---
 java/openjdk17/Makefile | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/java/openjdk17/Makefile b/java/openjdk17/Makefile
index e7039439f653..de71b4b482bb 100644
--- a/java/openjdk17/Makefile
+++ b/java/openjdk17/Makefile
@@ -139,11 +139,7 @@ CONFIGURE_ARGS+=	--with-extra-ldflags="-Wl,-rpath=${LOCALBASE}/lib/gcc${GCC_DEFA
 			--with-extra-cxxflags="-Wl,-rpath=${LOCALBASE}/lib/gcc${GCC_DEFAULT}"
 .else
 MAKE_ENV+=	USE_CLANG=true
-EXTRA_CFLAGS+=		-Wno-unused-but-set-parameter
-EXTRA_CFLAGS+=		-Wno-bitwise-instead-of-logical
-EXTRA_CFLAGS+=		-Wno-deprecated-non-prototype
-CONFIGURE_ARGS+=	--with-extra-cflags="${EXTRA_CFLAGS}"
-CONFIGURE_ARGS+=	--with-extra-cxxflags="${EXTRA_CFLAGS}"
+CONFIGURE_ARGS+=	--disable-warnings-as-errors
 .endif
 
 .if ${ARCH} == aarch64 || ${ARCH:Mpowerpc64*}