Re: git: 3fd626858d82 - 2023Q1 - devel/rgbds: Fix build on 12.4
Date: Tue, 28 Mar 2023 10:56:10 UTC
Hello danfe!
Thank you so much! I did test it without _POSIX_C_SOURCE but it failed at
first because I did a mistake on reinplace cmd.
It builds fine now.
Also, OpenBSD is doing same to fix build until upstream fixes it:
https://github.com/gbdev/rgbds/issues/1111
https://cgit.freebsd.org/ports/commit/?id=e4d330bbdc82f346bc31f109ebff0d71154362d0
Cheers,
Alexey Dokuchaev <danfe@freebsd.org> escreveu no dia terça, 28/03/2023 à(s)
09:06:
> On Tue, Mar 28, 2023 at 08:25:06AM +0100, Nuno Teixeira wrote:
> > Hello,
> >
> > Upstream can't solve problem with clang >10
> > https://github.com/gbdev/rgbds/issues/1091
>
> It builds fine for me with default compiler (12.4/13.1) and this target:
>
> post-patch:
> # yank _POSIX_C_SOURCE because it breaks the build
> ${REINPLACE_CMD} 's,-D_POSIX_C_SOURCE=200809L,,' ${WRKSRC}/Makefile
>
> Good code should not pass custom _POSIX_C_SOURCE anyway. :)
>
> ./danfe
>
--
Nuno Teixeira
FreeBSD Committer (ports)