git: c852714ad502 - 2023Q2 - emulators/virtualbox-ose-legacy: build fails on FreeBSD 12.4, 13.1 and 13.2 (all supported releases)

From: Vladimir Druzenko <vvd_at_FreeBSD.org>
Date: Tue, 06 Jun 2023 10:08:44 UTC
The branch 2023Q2 has been updated by vvd:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c852714ad50261e47784429342129a26b48bd402

commit c852714ad50261e47784429342129a26b48bd402
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2023-06-06 09:57:47 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2023-06-06 10:08:34 +0000

    emulators/virtualbox-ose-legacy: build fails on FreeBSD 12.4, 13.1 and 13.2 (all supported releases)
    
    llvm 13 and 14 included in FreeBSD fails to compile, force llvm 15 on
    all versions of the FreeBSD except lastest 13 and 14 where the llvm 15
    is included.
    Keep possibility to define different llvm via VBOX_LLVM_VER in make.conf.
    
    PR:                     265539
    Reported by:            freebsd@charles.lecklider.org
    Tested by:              grahamperrin
    Approved by:            tcberner (mentor)
    Differential Revision:  https://reviews.freebsd.org/D40408
    
    (cherry picked from commit 8febe8bdd5601e924af96ccef69b1f367269ff8a)
---
 emulators/virtualbox-ose-legacy/Makefile | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/emulators/virtualbox-ose-legacy/Makefile b/emulators/virtualbox-ose-legacy/Makefile
index 473396c87ce0..aeaf88108f43 100644
--- a/emulators/virtualbox-ose-legacy/Makefile
+++ b/emulators/virtualbox-ose-legacy/Makefile
@@ -206,22 +206,16 @@ KMK_FLAGS+=	-j${MAKE_JOBS_NUMBER}
 
 .include <bsd.port.pre.mk>
 
-.if ${OPSYS} == FreeBSD
-.if ${OSVERSION} >= 1400059
-BROKEN=		Fails to compile with libc++ 14.0.3
-.elif ${OSVERSION} >= 1301000 && ${OSVERSION} < 1400000
-BROKEN=		Fails to compile: error: ran out of registers during register allocation
-.endif
-.endif
-
-.if ${CHOSEN_COMPILER_TYPE} == clang && ${OPSYS} == FreeBSD && ${OSVERSION} > 1400022
-# clang > 11 included in FreeBSD 14 fails to compile this legacy version
-# of virtualbox-ose, force clang 11 on FreeBSD 14 where a newer clang is
-# included.
+.if ${CHOSEN_COMPILER_TYPE} == clang && ${OPSYS} == FreeBSD && \
+    (${OSVERSION} < 1302505 || (${OSVERSION} >= 1400000 && ${OSVERSION} < 1400079))
+# llvm 13 and 14 included in FreeBSD fails to compile this legacy version of
+# virtualbox-ose, force llvm 15 on all versions of the FreeBSD except lastest 13
+# and 14 where the llvm 15 is included: PR#265539.
+# Keep possibility to define different llvm via VBOX_LLVM_VER in make.conf.
 BUILD_DEPENDS+=	clang${VBOX_LLVM_VER}:devel/llvm${VBOX_LLVM_VER}
 CC=		clang${VBOX_LLVM_VER}
 CXX=		clang++${VBOX_LLVM_VER}
-VBOX_LLVM_VER?=	11
+VBOX_LLVM_VER?=	15
 .endif
 
 .if ${PYTHON_MAJOR_VER} >= 3