Re: git: be94cf5e3390 - 2026Q3 - net/freerdp3: Update 3.31.0 => 3.31.1

On Sun 06 Sep 17:47, Vladimir Druzenko wrote:
> The branch 2026Q3 has been updated by vvd:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=be94cf5e3390c0b7d342a63e8aa3984ee8ed29ad
> 
> commit be94cf5e3390c0b7d342a63e8aa3984ee8ed29ad
> Author:     Vladimir Druzenko <vvd@FreeBSD.org>
> AuthorDate: 2026-09-06 17:39:34 +0000
> Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
> CommitDate: 2026-09-06 17:47:47 +0000
> 
>     net/freerdp3: Update 3.31.0 => 3.31.1
>     
>     Changelog:
>     https://github.com/FreeRDP/FreeRDP/releases/tag/3.31.1
>     
>     Sponsored by:   UNIS Labs
>     MFH:            2026Q3
>     
>     (cherry picked from commit 12007fbb4c48122c6c306e7b2b863f9b6aef7a06)
> ---
>  net/freerdp3/Makefile  | 24 +++++++++++++++++-------
>  net/freerdp3/distinfo  |  6 +++---
>  net/freerdp3/pkg-plist |  2 ++
>  3 files changed, 22 insertions(+), 10 deletions(-)
> 
> diff --git a/net/freerdp3/Makefile b/net/freerdp3/Makefile
> index f7182f4d5dfe..2ec6b81d8afd 100644
> --- a/net/freerdp3/Makefile
> +++ b/net/freerdp3/Makefile
> @@ -1,5 +1,5 @@
>  PORTNAME=	freerdp
> -DISTVERSION=	3.31.0
> +DISTVERSION=	3.31.1
>  CATEGORIES=	net comms
>  MASTER_SITES=	https://pub.freerdp.com/releases/:freerdp \
>  		https://github.com/FreeRDP/FreeRDP/releases/download/${DISTVERSION}/:freerdp
> @@ -45,16 +45,16 @@ PLIST_SUB=	PATCHVERSION="${DISTVERSION}" \
>  OPTIONS_DEFINE=			ALSA AOM BROKENFOCUS CUPS DAV1D FAAC FAAD \
>  				FDKAAC FFMPEG GSM ICU JPEG LAME MANPAGES \
>  				OPENH264 OPUS PCSC PKCS11 PULSEAUDIO RDPECAM \
> -				SDL2 SDL3 SNDIO SOXR URIPARSER WAYLAND WEBVIEW \
> -				X11 YUV
> +				SDL2 SDL3 SNDIO SOXR URIPARSER VAAPI VAAPIH264 \
> +				WAYLAND WEBVIEW X11 YUV
>  OPTIONS_DEFINE_aarch64=		SIMD
>  OPTIONS_DEFINE_amd64=		SIMD
>  OPTIONS_DEFINE_armv7=		SIMD
>  OPTIONS_DEFINE_i386=		SIMD
> -OPTIONS_DEFAULT=		AAD CUPS FFMPEG GSSAPI_MIT ICU JSON_C \
> +OPTIONS_DEFAULT=		AAD AOM CUPS FFMPEG DAV1D GSSAPI_MIT ICU JSON_C \
>  				KEYBOARD_LAYOUT MANPAGES RDPECAM SDL2 SDL3 \
> -				SNDIO SWSCALE TIMEZONE_FILE WAYLAND WEBVIEW \
> -				X11 YUV
> +				SNDIO SWSCALE TIMEZONE_FILE VAAPI VAAPIH264 \
> +				WAYLAND WEBVIEW X11 YUV
>  OPTIONS_DEFAULT_aarch64=	SIMD
>  OPTIONS_DEFAULT_amd64=		SIMD
>  OPTIONS_DEFAULT_armv7=		SIMD
> @@ -89,6 +89,8 @@ SDL3_DESC=		Build FreeRDP SDL 3 client
>  SWSCALE_DESC=		Use SWScale image library for screen resizing (recommended)
>  TIMEZONE_FILE_DESC=	Support timezones as JSON resources (if OFF, compiled in is used)
>  URIPARSER_DESC=		Use uriparser RFC 3986 URI parsing library to handle URIs
> +VAAPI_DESC=		Use FFMPEG VAAPI (experimental, require FFMPEG)
> +VAAPIH264_DESC=		Use FFMPEG VAAPI hardware H264 encoding (experimental, require FFMPEG)

What's the point of adding 2 options that would confuse users when only one is
needed in particular they both bring the same dependency.

Bapt