Re: git: ff06e7790b96 - main - devel/esbuild: Update to 0.28.2

Hi Dave,
thank you for your reply.

On Fri, Oct 23, 2026 at 07:49:18AM +0200, Dave Cottlehuber wrote:
> On Fri, 23 Oct 2026, at 00:47, Sergey A. Osokin wrote:
> > On Thu, Oct 22, 2026 at 10:19:11PM +0000, Dave Cottlehuber wrote:
> >> The branch main has been updated by dch:
> >> 
> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=ff06e7790b96603a3f4598500a4b7790b99e5480
> >> 
> >> commit ff06e7790b96603a3f4598500a4b7790b99e5480
> >> Author:     Dave Cottlehuber <dch@FreeBSD.org>
> >> AuthorDate: 2026-10-22 11:03:20 +0000
> >> Commit:     Dave Cottlehuber <dch@FreeBSD.org>
> >> CommitDate: 2026-10-22 22:18:42 +0000
> >> 
> >>     devel/esbuild: Update to 0.28.2
> >
> > devel/esbuild/Makefile says:
> >
> >>  # DO NOT UPDATE WITHOUT THIS BEING DONE
> >>  # post to phabricator & chromium@ before committing so they can update
> >
> > However,
> >
> > % grep esbuild /usr/ports/www/chromium/distinfo 
> > SHA256 (evanw-esbuild-v0.28.1_GH0.tar.gz) = 
> > 65c756fa87d43178ac4a5242454c2bd0fde325f8ecf77997f8fa4b88f94d5cd2
> > SIZE (evanw-esbuild-v0.28.1_GH0.tar.gz) = 1997481
> >
> > and phabricator is still down.
> 
> Thanks Sergey
> 
> I am not sure what you want me to do?

You may want to fix the broken www/chromium port.

> Is something broken? If so what?
> 
> I posted a Phab review for chromium@ got no reply so I
> have contacted rnagy 2 weeks ago, got his approval and
> committed this. Thanks why this commit has the approved-by
> trailer.

That's fine.  However, that's not correct to update
devel/esbuild port without updating the www/chromium,
because of this:

% grep ^_ESBUILD_ /usr/ports/www/chromium/Makefile
_ESBUILD_VERSION=       ${MAKE} -C ${PORTSDIR}/devel/esbuild -V DISTVERSION

> AFAICT chromium fetches its own esbuild dependency now?
> 
> Is chromium broken? Or esbuild?

Yes, www/chromium is broken.

> Either way it’s up to chromium team to update their
> port, once they give me an ok to continue.

Thank you.

-- 
Sergey A. Osokin