Re: git: 09d59b2140bc - main - sysutils/qdirstat: fix build on armv7

On Mon, Mar 30, 2026 at 8:49 AM Robert Clausecker <fuz@freebsd.org> wrote:
>
> The branch main has been updated by fuz:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=09d59b2140bc16c125dbee5e007d0766c1aaa63d
>
> commit 09d59b2140bc16c125dbee5e007d0766c1aaa63d
> Author:     Robert Clausecker <fuz@FreeBSD.org>
> AuthorDate: 2026-03-24 20:06:35 +0000
> Commit:     Robert Clausecker <fuz@FreeBSD.org>
> CommitDate: 2026-03-30 15:44:02 +0000
>
>     sysutils/qdirstat: fix build on armv7
>
>     The operator << of the LogStream class is used to output numerical
>     values among other things.  The port tries to output a value of type
>     unsigned long long on armv7, while presumably not doing so on other
>     platforms.  Add an overload for unsigned long long to fix the build.

Can you open an upstream PR?

>     Approved by:    portmgr (build fix blanket)
>     MFH:            2026Q1
> ---
>  sysutils/qdirstat/files/patch-src_LogStream.cpp | 14 ++++++++++++++
>  sysutils/qdirstat/files/patch-src_LogStream.h   | 10 ++++++++++
>  2 files changed, 24 insertions(+)
>
> diff --git a/sysutils/qdirstat/files/patch-src_LogStream.cpp b/sysutils/qdirstat/files/patch-src_LogStream.cpp
> new file mode 100644
> index 000000000000..9eaba8d2ea25
> --- /dev/null
> +++ b/sysutils/qdirstat/files/patch-src_LogStream.cpp
> @@ -0,0 +1,14 @@
> +--- src/LogStream.cpp.orig     2026-03-24 20:00:19 UTC
> ++++ src/LogStream.cpp
> +@@ -155,6 +155,11 @@ LogStream & operator<<( LogStream & str, long long val
> +     return logStreamOut<long long>( str, val );
> + }
> +
> ++LogStream & operator<<( LogStream & str, unsigned long long val )
> ++{
> ++    return logStreamOut<unsigned long long>( str, val );
> ++}
> ++
> +
> + LogStream & operator<<( LogStream & str, bool val )
> + {
> diff --git a/sysutils/qdirstat/files/patch-src_LogStream.h b/sysutils/qdirstat/files/patch-src_LogStream.h
> new file mode 100644
> index 000000000000..e743aea9ac42
> --- /dev/null
> +++ b/sysutils/qdirstat/files/patch-src_LogStream.h
> @@ -0,0 +1,10 @@
> +--- src/LogStream.h.orig       2026-03-24 19:59:40 UTC
> ++++ src/LogStream.h
> +@@ -129,6 +129,7 @@ LogStream & operator<<( LogStream & str, long long
> + LogStream & operator<<( LogStream & str, long          val );
> + LogStream & operator<<( LogStream & str, unsigned long val );
> + LogStream & operator<<( LogStream & str, long long     val );
> ++LogStream & operator<<( LogStream & str, unsigned long long val );
> + LogStream & operator<<( LogStream & str, double        val );
> + LogStream & operator<<( LogStream & str, bool val );
> + LogStream & operator<<( LogStream & str, char val );
>