Re: git: 756ff0a53c87 - main - sysutils/msktutil: Fix build for FreeBSD >= 15
Date: Wed, 22 Jul 2026 15:35:55 UTC
On Wed, 2026-07-22 at 00:39, Daniel Engberg <diizzy@FreeBSD.org> wrote: > On 2026-07-22 00:33, Joseph Mingrone wrote: >> On Tue, 2026-07-21 at 17:59, "Dan Langille" <dan@langille.org> wrote: >>> On Tue, Jul 21, 2026, at 5:19 PM, Daniel Engberg wrote: >>>> On 2026-07-21 22:26, Dan Langille wrote: >>>>> The branch main has been updated by dvl: >>>>> URL: https://cgit.FreeBSD.org/ports/commit/?id=756ff0a53c87b6de3bd7303db91756615985e785 >>>>> commit 756ff0a53c87b6de3bd7303db91756615985e785 >>>>> Author: Dan Langille <dvl@FreeBSD.org> >>>>> AuthorDate: 2026-07-21 20:24:52 +0000 >>>>> Commit: Dan Langille <dvl@FreeBSD.org> >>>>> CommitDate: 2026-07-21 20:25:56 +0000 >>>>> sysutils/msktutil: Fix build for FreeBSD >= 15 >>>>> * Take maintainership >>>>> * While here, portfmt >>>>> PR: 292735 >>>>> --- >>>>> sysutils/msktutil/Makefile | 20 ++++++++++++-------- >>>>> 1 file changed, 12 insertions(+), 8 deletions(-) >>>> Port doesn't build after this change using Ports tree because it's >>>> missing inclusion of bsd.port.options.mk as documented in Porters Handbook. >>>> https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-extra >>>> Variable "OPSYS" is undefined >>> Thank you. I've been working on it. It passed both poudriere testport and bulk. >> Hi Dan(iel)?, >> Maybe you can detect Kerberos the same way the framework does. >> Mk/Uses/gssapi.mk:93 decides whether base Kerberos is MIT or Heimdal >> with exists(/usr/libdata/pkgconfig/mit-krb5.pc), and exists() works at >> parse time with no framework variables. >> GSSAPI_BASE_USES= gssapi >> .if exists(/usr/libdata/pkgconfig/mit-krb5.pc) >> GSSAPI_BASE_CONFIGURE_ON= --with-krb5=mit >> .else >> GSSAPI_BASE_CONFIGURE_ON= --with-krb5=heimdal >> .endif >> Joe Hello Daniel, > While possible I'm not very fond of these since they tend to get stale and we already have a good established way of pruning checks based on version aka rene@. I didn't have a lot of time to research solutions, hence "Maybe you can...". I'm unsure what you mean by "aka rene." I don't see any messages from rene@ in this thread. On Tue, 2026-07-21 at 23:19, Daniel Engberg <diizzy@FreeBSD.org> wrote: > Port doesn't build after this change using Ports tree because it's missing inclusion of bsd.port.options.mk as documented in Porters Handbook. > https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-extra As Dan discovered, simply adding .include <bsd.port.options.mk> above the .if won't work here. GSSAPI_BASE_CONFIGURE_ON, assigned after the include, will get set to --with-krb5=mit, but CONFIGURE_ARGS will not contain --with-krb5=mit. No warning, no error. Kind regards, Joe P.S. I (and my significant other) hope I can do a better job staying away from computers until the beginning August. https://wiki.freebsd.org/afk. (Only those logged into the wiki will see that page.)