Re: git: 756ff0a53c87 - main - sysutils/msktutil: Fix build for FreeBSD >= 15
- In reply to: Daniel Engberg : "Re: git: 756ff0a53c87 - main - sysutils/msktutil: Fix build for FreeBSD >= 15"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 21 Jul 2026 22:43:40 UTC
On Tue, Jul 21, 2026, at 6:39 PM, Daniel Engberg wrote: > On 2026-07-22 00:33, Joseph Mingrone wrote: >> On Tue, 2026-07-21 at 17:59, "Dan Langille" <dan@langille.org> wrote: >> >>> On Tue, Jul 21, 2026, at 5:19 PM, Daniel Engberg wrote: >>>> On 2026-07-21 22:26, Dan Langille wrote: >>>>> The branch main has been updated by dvl: >> >>>>> URL: https://cgit.FreeBSD.org/ports/commit/?id=756ff0a53c87b6de3bd7303db91756615985e785 >> >>>>> commit 756ff0a53c87b6de3bd7303db91756615985e785 >>>>> Author: Dan Langille <dvl@FreeBSD.org> >>>>> AuthorDate: 2026-07-21 20:24:52 +0000 >>>>> Commit: Dan Langille <dvl@FreeBSD.org> >>>>> CommitDate: 2026-07-21 20:25:56 +0000 >> >>>>> sysutils/msktutil: Fix build for FreeBSD >= 15 >> >>>>> * Take maintainership >>>>> * While here, portfmt >> >>>>> PR: 292735 >>>>> --- >>>>> sysutils/msktutil/Makefile | 20 ++++++++++++-------- >>>>> 1 file changed, 12 insertions(+), 8 deletions(-) >> >>>> Port doesn't build after this change using Ports tree because it's >>>> missing inclusion of bsd.port.options.mk as documented in Porters Handbook. >>>> https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-extra >> >>>> Variable "OPSYS" is undefined >> >>> Thank you. I've been working on it. It passed both poudriere testport and bulk. >> >> Hi Dan(iel)?, >> >> Maybe you can detect Kerberos the same way the framework does. >> Mk/Uses/gssapi.mk:93 decides whether base Kerberos is MIT or Heimdal >> with exists(/usr/libdata/pkgconfig/mit-krb5.pc), and exists() works at >> parse time with no framework variables. >> >> GSSAPI_BASE_USES= gssapi >> .if exists(/usr/libdata/pkgconfig/mit-krb5.pc) >> GSSAPI_BASE_CONFIGURE_ON= --with-krb5=mit >> .else >> GSSAPI_BASE_CONFIGURE_ON= --with-krb5=heimdal >> .endif >> >> Joe > > While possible I'm not very fond of these since they tend to get stale > and we already have a good established way of pruning checks based on > version aka rene@. If you know a better way, I'm ready for it. `poudriere testport` is complaining if I start using .include <bsd.port.options.mk> : The following options helpers are incorrectly set after bsd.port.options.mk and are ineffective: GSSAPI_BASE_USES GSSAPI_BASE_CONFIGURE_ON ... etc If I move it down too far, it's after the use of OPSY and we're back to the original error. -- Dan Langille dan@langille.org