Re: git: 6c7bfd6a6aab - main - biology/muscle: update 3.8.1551 -> 5.1
Date: Tue, 21 Jul 2026 12:14:42 UTC
On Tue, Jul 21, 2026 at 09:52:00AM +0000, Rodrigo Osorio wrote:
> commit 6c7bfd6a6aab06279041e5d5b9c63a1dec8a24dd
>
> biology/muscle: update 3.8.1551 -> 5.1
> [...]
> +LICENSE= GPLv3
>
> -USES= dos2unix gmake
> -NO_WRKSUBDIR= yes
> -DOS2UNIX_GLOB= *.cpp
Hello Rodrigo,
I see some problems with this commit:
> +BUILD_DEPENDS= bash:shells/bash
It's not really needed: it's hardcoded in the `gitver.bash', a
a simple, POSIX-compatible script calling "git describe" which
won't work for *_GH0.tar.gz archives anyway.
> +USE_GCC= yes
Why default compiler isn't sufficient? Commit log doesn't
mention this. Any deviation from the defaults should be
explained accordingly.
> +BINARY_ALIAS= g++=g++14
You're hardcoding version here without specifying it anywhere
in the Makefile. Once GCC_DEFAULT changes this would break.
> do-install:
> - ${INSTALL_PROGRAM} ${WRKSRC}/muscle ${STAGEDIR}${PREFIX}/bin
> + cd ${WRKSRC} && \
> + ${INSTALL} ${OPSYS}/muscle ${STAGEDIR}${PREFIX}/bin/
So you replaced a single command one-liner with two-line &&-conditional
and demoted INSTALL_PROGRAM -> INSTALL, how's that an improvement?
./danfe