Re: git: 2782ca6976fc - main - www/srt: add SRTFFPLAY option

In reply to: Yuri Victorovich : "git: 2782ca6976fc - main - www/srt: add SRTFFPLAY option"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Daniel Engberg <diizzy_at_FreeBSD.org>
Date: Tue, 21 Jul 2026 06:58:45 UTC

On 2026-07-21 07:51, Yuri Victorovich wrote:
> The branch main has been updated by yuri:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=2782ca6976fccd5b35a87022e2bcada8ee46b2e1
>
> commit 2782ca6976fccd5b35a87022e2bcada8ee46b2e1
> Author:     Juhani Krekelä <juhani@krekela.fi>
> AuthorDate: 2026-07-21 05:50:13 +0000
> Commit:     Yuri Victorovich <yuri@FreeBSD.org>
> CommitDate: 2026-07-21 05:50:13 +0000
>
>      www/srt: add SRTFFPLAY option
>      
>      PR:             293009
> ---
>   www/srt/Makefile  | 12 +++++++++---
>   www/srt/pkg-plist |  2 +-
>   2 files changed, 10 insertions(+), 4 deletions(-)
>
> ....
>   
>   OPTIONS_RADIO=		CRYPTO
>   OPTIONS_RADIO_CRYPTO=	GNUTLS OPENSSL
> -OPTIONS_DEFAULT=	OPENSSL
> +OPTIONS_DEFINE=		OPENSSL SRTFFPLAY
> +OPTIONS_DEFAULT=	OPENSSL SRTFFPLAY
> +OPTIONS_SUB=		yes
> +

Hi,

OPTIONS_DEFINE should not contain OPENSSL according to Porters Handbook 
and OPTION_DEFINE should be placed before OPTIONS_RADIO variables.
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-options-options
https://docs.freebsd.org/en/books/porters-handbook/book/#porting-order-options

Best regards,
Daniel