Re: git: 13896b356c7e - main - java/openjdk21: pass MAKE_JOBS_NUMBER around

*Van:* Vladimir Druzenko <vvd@freebsd.org>
*Datum:* dinsdag, 23 september 2025 14:59
*Aan:* Ronald Klop <ronald@FreeBSD.org>
*CC:* ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
*Onderwerp:* Re: git: 13896b356c7e - main - java/openjdk21: pass MAKE_JOBS_NUMBER around

    Hello!
    23.09.2025 13:31, Ronald Klop :
     > The branch main has been updated by ronald:
     >
     > URL: https://cgit.FreeBSD.org/ports/commit/?id=13896b356c7ee05910913cd82b243da8f656684c <https://cgit.FreeBSD.org/ports/commit/?id=13896b356c7ee05910913cd82b243da8f656684c>
     >
     > commit 13896b356c7ee05910913cd82b243da8f656684c
     > Author:     Ronald Klop <ronald@FreeBSD.org>
     > AuthorDate: 2025-09-23 10:25:57 +0000
     > Commit:     Ronald Klop <ronald@FreeBSD.org>
     > CommitDate: 2025-09-23 10:31:01 +0000
     >
     >      java/openjdk21: pass MAKE_JOBS_NUMBER around
     >
     >      Be more verbose during the build to prevent output timeout.
     >
     >      For rationale of this change see the commits in java/openjdk17 of the
     >      last two weeks.
     > ---
     >   java/openjdk21/Makefile | 5 +++++
     >   1 file changed, 5 insertions(+)
     >
     > diff --git a/java/openjdk21/Makefile b/java/openjdk21/Makefile
     > index 6162d28e0a8d..be96b112ab09 100644
     > --- a/java/openjdk21/Makefile
     > +++ b/java/openjdk21/Makefile
     > @@ -1,6 +1,7 @@
     >   PORTNAME=   openjdk
     >   DISTVERSIONPREFIX=  jdk-
     >   DISTVERSION=    ${JDK_MAJOR_VERSION}.${JDK_MINOR_VERSION}.${JDK_PATCH_VERSION}+${JDK_BUILD_NUMBER}-${BSD_JDK_VERSION}
     > +PORTREVISION=    1
     >   CATEGORIES= java devel
     >   PKGNAMESUFFIX?= ${JDK_MAJOR_VERSION}
     >
     > @@ -38,6 +39,8 @@ GH_PROJECT= jdk21u
     >
     >   NO_CCACHE=  yes
     >
     > +# Suppress passing -j to do-build target via Mk/bsd.port.mk
     > +# In the JDK build the number of parallel jobs is passed in via configure --with-num-cores=N
     >   _MAKE_JOBS= #
     >   MAKE_ENV=   LANG="C" \
     >           LC_ALL="C" \
     > @@ -47,6 +50,7 @@ MAKE_ENV=   LANG="C" \
     >           CC=${CC} \
     >           CXX=${CXX} \
     >           CPP=${CPP} \
     > +     LOG=cmdlines \
     >           MAKEFLAGS=""
     >
     >   JDK_OSARCH= bsd-${ARCH:S/amd64/x86_64/:S/i386/x86/:S/powerpc64/ppc64/}
     > @@ -88,6 +92,7 @@ CONFIGURE_ARGS= --with-boot-jdk=${BOOTSTRAPJDKDIR} \
     >           --with-giflib-lib=${LOCALBASE}/lib \
     >           --with-harfbuzz=system \
     >           --with-libpng=system \
     > +     --with-num-cores=${MAKE_JOBS_NUMBER} \
     >           --with-zlib=system \
     >           --with-lcms=system \
     >           --x-includes=${LOCALBASE}/include \

    Do these changes only affect the build process and not the runtime?
    If so, then why is there a PORTREVISION bump? Waste of electricity and time…

    -- 
    Best regards,
    Vladimir Druzenko
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------



Thanks for your remark.

Because, when a pkg build failure happens or somebody complains about a ports build on their computer the portrevision makes it so much more easy for me to see if the build was with or without my changes.

Regards,
Ronald.