Re: git: 1a2da0563af1 - main - devel/libblake3: New port: C library providing BLAKE3
Date: Sat, 13 Sep 2025 21:51:18 UTC
On 2025-09-13 23:26, Ashish SHUKLA wrote: > The branch main has been updated by ashish: > > URL:https://cgit.FreeBSD.org/ports/commit/?id=1a2da0563af14cc02aea7d1a95a4d4875618c40e > > commit 1a2da0563af14cc02aea7d1a95a4d4875618c40e > Author: Ashish SHUKLA<ashish@FreeBSD.org> > AuthorDate: 2025-09-13 21:05:26 +0000 > Commit: Ashish SHUKLA<ashish@FreeBSD.org> > CommitDate: 2025-09-13 21:13:23 +0000 > > devel/libblake3: New port: C library providing BLAKE3 > > ..... Hi, You get a warning with DEVELOPER=yes (this should always be enabled) --- You are using USE_GITHUB and WRKSRC is set which is wrong. Set GH_PROJECT correctly or set WRKSRC_SUBDIR and remove WRKSRC entirely. --- Please use WRKSRC_SUBDIR as suggested CMAKE_ARGS+= -DBUILD_SHARED_LIBS:BOOL=true Can be simplified by using CMAKE_ON= BUILD_SHARED_LIBS PLIST_SUB+= should be PLIST_SUB= https://docs.freebsd.org/en/books/porters-handbook/book/#plist-sub It would also be nice if you could enable unit testing (make test) for regression tests Best regards, Daniel