From nobody Sat Sep 06 23:05:49 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cK82j47R8z65mCc; Sat, 06 Sep 2025 23:05:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cK82j3PKSz3LPm; Sat, 06 Sep 2025 23:05:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757199949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rrbG+9fbAD1ZpYPtqe3Ag/UJoPbwPNGE1JW9e+vLrkw=; b=MkPQpcB52rWOODJkei5fEPZ4nNYNtCy1pt+IkQuyhW4SE4n1wWyKGzOHuf3HntrqE2oDHX UQMbPFrVmlM5veeaJ4mCi8jglKDyB05jsScqX9vcSLTS51bmA3URIFJEtvtUFFfsJ9oCQk jf80rXxsDmUh6aNj3QHQOY62MPoxHz+EHzLLow3nNJhQ/KLSBBw8DOUgnTJbWhnk492HCh wkjqEWt0Mk5fk/rozn7BJ0asX0PznopABzR6xRIsDCATKt5bSYeWEGG+w5EyCXxMVe/pVz c3n2Oy3egO0GjVN4D3fy2PtwxtEyb5HQhyLKa5/kSU1zaA60cHkfk/NEpRRB9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757199949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rrbG+9fbAD1ZpYPtqe3Ag/UJoPbwPNGE1JW9e+vLrkw=; b=dk25moaViqC2btpq5jlBocLbizDb9Wke7AmuYuwGu1IfxoPCn4KkgtI07Y0E9dEOwuLW7E 5r6JwEnwr90OPTlORG2VztHns5pam2/UzDQJPOonaxnZ5Yqb058vvKAyoqilbF6EHjoVtf 2EKXs4IrklNbiqj2NEr5I+rlmq+k/53TnwV1QdrcxruITocJ3xAda4gae/HvgODgNiZA8I xgQXm5Q7UKquwHc6qno6eTb27hTyvvBO576hPBRxJtEwekR4Nrkbri3P+5z6Ro88qR/2bi c6SeYzjjRDfQM0G+7uXQEjgWJrvb8TU6cj/kM4jPeTWIMAydwXRdVM7bm8qNoQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757199949; a=rsa-sha256; cv=none; b=hdAWp7y4r1WaoEUiU3lGw0svxrHFSbbDZWKDI+T5gr4oByvubyoL8WuETKBmyd4Pk6VoyM nl9qxe5EIBMOmjPWn4jHopdi/NhWiaJjBdaK4lRuWt/iWM8gypl3OyTRJLo2X9mU4lOT8f 3CsdGlHG+sYfH73MKubFBvv/xpWpnxnfCmVC6bXHJIpwiH2EecNZlwwNKFJn//EFmr8npn aFQIj+9YuSLDoWFRMxrMjsaTdtRf1jnC7dn7hUR01ddndFZvLx9l7QyH2wxVlVzO8xbPtB ReJEL0Ia5ldbatysqKdqfPi5gGnl0t4mVUWd5yHwpqy4J50gpkmhE1bU5eYmMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cK82j2hhxzvpl; Sat, 06 Sep 2025 23:05:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 586N5n2F095106; Sat, 6 Sep 2025 23:05:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 586N5nOH095103; Sat, 6 Sep 2025 23:05:49 GMT (envelope-from git) Date: Sat, 6 Sep 2025 23:05:49 GMT Message-Id: <202509062305.586N5nOH095103@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Vladimir Druzenko Subject: git: b7c34da93ef6 - main - sysutils/slurm-wlm: Fix: slurmd: error: Unable to initialize cgroup plugin List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vvd X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b7c34da93ef6159f7d4989e2d96f551fef6a7f8f Auto-Submitted: auto-generated The branch main has been updated by vvd: URL: https://cgit.FreeBSD.org/ports/commit/?id=b7c34da93ef6159f7d4989e2d96f551fef6a7f8f commit b7c34da93ef6159f7d4989e2d96f551fef6a7f8f Author: Generic Rikka AuthorDate: 2025-09-06 23:03:01 +0000 Commit: Vladimir Druzenko CommitDate: 2025-09-06 23:03:01 +0000 sysutils/slurm-wlm: Fix: slurmd: error: Unable to initialize cgroup plugin When trying to run slurmd -Dvvv, slurmd produces the following output and crashes: slurmd: debug: Log file re-opened slurmd: debug2: hwloc_topology_init slurmd: debug2: hwloc_topology_load slurmd: debug2: hwloc_topology_export_xml slurmd: debug: CPUs:4 Boards:1 Sockets:1 CoresPerSocket:4 ThreadsPerCore:1 slurmd: error: Unable to initialize cgroup plugin slurmd: error: slurmd initialization failed Conditionally remove cgroups support on FreeBSD, to prevent slurmd from crashing due to missing cgroups support. PR: 288617 Differential Revision: https://reviews.freebsd.org/D52138 MFH: 2025Q3 --- sysutils/slurm-wlm/Makefile | 2 +- .../files/patch-src_slurmd_slurmd_slurmd.c | 50 ++++++++++++++++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/sysutils/slurm-wlm/Makefile b/sysutils/slurm-wlm/Makefile index a676f4bb7ad2..b3532a0fbfd5 100644 --- a/sysutils/slurm-wlm/Makefile +++ b/sysutils/slurm-wlm/Makefile @@ -1,6 +1,6 @@ PORTNAME= slurm DISTVERSION= 23.11.7 -PORTREVISION= 10 +PORTREVISION= 11 CATEGORIES= sysutils MASTER_SITES= https://download.schedmd.com/slurm/ PKGNAMESUFFIX= -wlm diff --git a/sysutils/slurm-wlm/files/patch-src_slurmd_slurmd_slurmd.c b/sysutils/slurm-wlm/files/patch-src_slurmd_slurmd_slurmd.c new file mode 100644 index 000000000000..cb9dcc42879a --- /dev/null +++ b/sysutils/slurm-wlm/files/patch-src_slurmd_slurmd_slurmd.c @@ -0,0 +1,50 @@ +--- src/slurmd/slurmd/slurmd.c.orig 2024-05-21 17:19:51 UTC ++++ src/slurmd/slurmd/slurmd.c +@@ -2191,10 +2191,17 @@ _slurmd_init(void) + build_all_frontend_info(true); + + /* ++ * cgroups is unsupported on FreeBSD and would prevent slurmd from starting ++ */ ++#if defined(__FreeBSD__) ++ info("FreeBSD: Skipping cgroup_conf_init() - cgroups unsupported"); ++#else ++ /* + * This needs to happen before _read_config where we will try to read + * cgroup.conf values + */ + cgroup_conf_init(); ++#endif + + xcpuinfo_refresh_hwloc(original); + +@@ -2214,6 +2221,10 @@ _slurmd_init(void) + * defaults and command line. + */ + _read_config(); ++ ++#if defined(__FreeBSD__) ++ info("FreeBSD: Skipping cgroup_g_init() - cgroups unsupported"); ++#else + /* + * This needs to happen before _resource_spec_init where we will try to + * attach the slurmd pid to system cgroup, and after _read_config to +@@ -2223,6 +2234,7 @@ _slurmd_init(void) + error("Unable to initialize cgroup plugin"); + return SLURM_ERROR; + } ++#endif + + #ifndef HAVE_FRONT_END + if (!find_node_record(conf->node_name)) +@@ -2562,6 +2574,10 @@ static int _resource_spec_init(void) + */ + static int _resource_spec_init(void) + { ++#if defined(__FreeBSD__) ++ debug("FreeBSD: Skipping system cpuset and memory cgroup setup"); ++ return SLURM_SUCCESS; ++#endif + fini_system_cgroup(); /* Prevent memory leak */ + if (_core_spec_init() != SLURM_SUCCESS) + error("Resource spec: core specialization disabled");