Re: git: 4030b7d57c68 - main - devel/opentelemetry-cpp: fix build error

From: Po-Chuan Hsieh <sunpoet_at_freebsd.org>
Date: Sun, 30 Nov 2025 06:56:01 UTC 
On Sun, Nov 30, 2025 at 1:52 PM Matthias Fechner <mfechner@freebsd.org>
wrote:

> The branch main has been updated by mfechner:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=4030b7d57c68fda7bad3230379790065dbb1ed39
>
> commit 4030b7d57c68fda7bad3230379790065dbb1ed39
> Author:     Matthias Fechner <mfechner@FreeBSD.org>
> AuthorDate: 2025-11-30 05:50:26 +0000
> Commit:     Matthias Fechner <mfechner@FreeBSD.org>
> CommitDate: 2025-11-30 05:50:26 +0000
>
>     devel/opentelemetry-cpp: fix build error
>
>     Added devel/c4core as a lib dependency:
>     ====> Running Q/A tests (stage-qa)
>     Error: /usr/local/lib/libopentelemetry_configuration.so.1.24.0 is
> linked to /usr/local/lib/libc4core.so.0.2.6 from devel/c4core but it is not
> declared as a dependency
>     Warning: you need LIB_DEPENDS+=libc4core.so:devel/c4core
>     Warning: you might not need LIB_DEPENDS on libcurl.so
>     Warning: you might not need LIB_DEPENDS on libgtest.so
>     *** Error code 1
>
>     Approved by:    just-fix-it
>

This is incorrect.
It is an indirect dependency brought by devel/rapidyaml.
Since it is not a direct dependency, it should not be added to LIB_DEPENDS.


> ---
>  devel/opentelemetry-cpp/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/devel/opentelemetry-cpp/Makefile
> b/devel/opentelemetry-cpp/Makefile
> index 65622b0ee5b9..7b5c7e99f3a1 100644
> --- a/devel/opentelemetry-cpp/Makefile
> +++ b/devel/opentelemetry-cpp/Makefile
> @@ -1,6 +1,7 @@
>  PORTNAME=      opentelemetry-cpp
>  PORTVERSION=   1.24.0
>  DISTVERSIONPREFIX=     v
> +PORTREVISION=  1
>  CATEGORIES=    devel
>
>  MAINTAINER=    sunpoet@FreeBSD.org
> @@ -11,7 +12,8 @@ WWW=          https://opentelemetry.io/ \
>  LICENSE=       APACHE20
>  LICENSE_FILE=  ${WRKSRC}/LICENSE
>
> -LIB_DEPENDS=   libcurl.so:ftp/curl \
> +LIB_DEPENDS=   libc4core.so:devel/c4core \
> +               libcurl.so:ftp/curl \
>                 libgtest.so:devel/googletest \
>                 libryml.so:devel/rapidyaml
>  TEST_DEPENDS=  benchmark>=0:devel/benchmark
>
>