Re: git: b4a4910b55ef - main - dns/aardvark-dns: add new port
- In reply to: Gleb Popov : "Re: git: b4a4910b55ef - main - dns/aardvark-dns: add new port"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 18 Nov 2025 17:09:37 UTC
On Tue, Nov 18, 2025 at 07:49:01PM +0300, Gleb Popov wrote: > On Tue, Nov 18, 2025 at 7:42 PM Daniel Engberg <diizzy@freebsd.org> wrote: > > This is looks not ideal? :-) > > Why is libinotify always pulled in as a dependency if it's in base? > > For consistency with the rest of the tree probably better to use > > OSVERSION or OSREL/OSREL:R instead of just checking that it exists. > > Checking for file existence is actually more consistent - other > inotify-sensitive ports are already doing that. > But I agree that LIB_DEPENDS should be under the condition too. I do believe that USES should happen in this case, and all other things, linke checking if exists or doesn't + dependencies management should be done behind the scene. And, yes, that should happen for all new features are coming with future releases. -- Sergey A. Osokin