Re: git: b4a4910b55ef - main - dns/aardvark-dns: add new port

On 2025-11-18 17:49, Gleb Popov wrote:
> On Tue, Nov 18, 2025 at 7:42 PM Daniel Engberg <diizzy@freebsd.org> wrote:
>> Hi,
>>
>> This is looks not ideal? :-)
>> Why is libinotify always pulled in as a dependency if it's in base?
>> For consistency with the rest of the tree probably better to use
>> OSVERSION or OSREL/OSREL:R instead of just checking that it exists.
> 
> Checking for file existence is actually more consistent - other
> inotify-sensitive ports are already doing that.
> But I agree that LIB_DEPENDS should be under the condition too.

My reasoning is for consistency and at least trying to keep the tree 
relatively tidy. Once versions goes EoL it's much easier to grep the 
tree for OSVERSION or OSREL (which people already do) than looking for 
various "random" file checks which aren't documented.

Best regards,
Daniel