From nobody Tue Nov 18 16:49:01 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d9rDp00zTz6HQfB for ; Tue, 18 Nov 2025 16:49:30 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d9rDn40Y6z4NyR for ; Tue, 18 Nov 2025 16:49:29 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-787eb2d8663so37847b3.0 for ; Tue, 18 Nov 2025 08:49:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763484568; x=1764089368; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RdQD74nHt8w9+bLyRK9I03FfNpWTXHOvULrEk44KcC8=; b=dsA7KQ7paELQu0H6iK9XpHZROZMxEzCiRn1LnVq1yUoK4KsLwFZMOn34a18hZKrUia gTWzj2ePdmK4JFBBztj3WzSiw9ztFUmXKfGfIq2Tk0Iag1itX/sYf2LAYsHAK7yhB4s+ NbRwoWg05lQZ4Y9BmGP9YsOcJtIj0K40CTAfsJQEK62H1ePeOAavWajdRBmhR/IXZ/0b ZFzffE3EKvE87moic6dBwV1FIyitfB6UeqiukzcacBSBQ48zAwyCA9gd10OB2qRAPl8d VW+Qucv/vSSj3SLcfpelieEBIElyvXFim/umJGWrSDbzbbJDxsompbhLf6F0LzY1cAiB mI2g== X-Forwarded-Encrypted: i=1; AJvYcCVY4GlmyLP/mNv2xcIwGfvxs+R2oXkiYbX+qF23VAJ7yMOl7po685sJMzTuXTZCqIfRxqZ3m9OSCGeOpQ0v5sBRLCNG0cY=@freebsd.org X-Gm-Message-State: AOJu0YyxWQk28YO8cM2RY+b62NNX4zAYZ004mfESEA668hFBGhT6AjvA P0smG/Lban9PAh/+jh24BFxQCiUvJrRiLerNIaSxSlDNdzBpbZKDYD4rJM0Uc3WP X-Gm-Gg: ASbGnctUnQ1JyAfoaPB0Ubx9ub1zb95gTXqSF2QK0pGcFnnxe+m2pnv2W5Eq1IjfINn Q/NDdB0kUN6Iy9eftEKZD8LrZ8ft4GURFYiGJFD52rLedsjGI2m0RIowGgPxaH+25snFJhgoMlm dj1YV/QQhX1Nkg1eW/xdNYCigyKHlVSEODUmr0GNkNiygyUzLQt3PXJ9ve5f2asMmJJy8dYUuHl 3Xo+cZcdDJCw1hUxw/jyrZWcZSp6XojyapTH74reZaK0JxocFBHdL7aSNg3/uUAQ1gxZWeXkraT C4KX2jEuNMlHEQqH/ENkdhV7mUMKGBeL2j/BWTUkug/ATMFPDTxrcpZMaS5wsMBHUhi4hWRaOX+ L5SBS1n49TOpsp1fsnIV4yr7OVo07/W+AiNRPg4P48wcjpZ8EVy2KCv/64BLDGCRJymRt45BiCG NksSy7hHhHRP1ay9MPaMjfflZ/BRp/xm4K8VFXwxhWMOUhG+U57StJib8bwqhF X-Google-Smtp-Source: AGHT+IEvoL0j/DnGhJQ87GbdaP4ecqr+kAfrmfKWY930C8bZ9yo+RKU2UsqBMlbCrZzyTt6wI6s2CQ== X-Received: by 2002:a05:690e:1246:b0:63f:b330:8c85 with SMTP id 956f58d0204a3-642ebafe1b7mr123734d50.18.1763484568313; Tue, 18 Nov 2025 08:49:28 -0800 (PST) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6410ea03b40sm6080225d50.10.2025.11.18.08.49.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 08:49:28 -0800 (PST) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-787eb2d8663so37357b3.0 for ; Tue, 18 Nov 2025 08:49:27 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX0iry9kH7pz1oNtUhFjeUJC3FkNTs+tKe3bdXebyBLly+P+ekCgtoqRRX1HGS4Z3f6iZYNwEcY8IOKtMDQm3bSKbIlgdM=@freebsd.org X-Received: by 2002:a05:690e:169b:b0:63f:b49c:6116 with SMTP id 956f58d0204a3-642ebb8e184mr113674d50.23.1763484567243; Tue, 18 Nov 2025 08:49:27 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 References: <691c97fb.3da01.9e98319@gitrepo.freebsd.org> In-Reply-To: From: Gleb Popov Date: Tue, 18 Nov 2025 19:49:01 +0300 X-Gmail-Original-Message-ID: X-Gm-Features: AWmQ_bmPkq-6IjesW3iWYqgOo1Ro7ZVVmjaZ9vRq2Vf90iSfXkNzyQrvn93Pyhw Message-ID: Subject: Re: git: b4a4910b55ef - main - dns/aardvark-dns: add new port To: Daniel Engberg Cc: "Sergey A. Osokin" , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4d9rDn40Y6z4NyR On Tue, Nov 18, 2025 at 7:42=E2=80=AFPM Daniel Engberg = wrote: > Hi, > > This is looks not ideal? :-) > Why is libinotify always pulled in as a dependency if it's in base? > For consistency with the rest of the tree probably better to use > OSVERSION or OSREL/OSREL:R instead of just checking that it exists. Checking for file existence is actually more consistent - other inotify-sensitive ports are already doing that. But I agree that LIB_DEPENDS should be under the condition too.