Re: git: b4a4910b55ef - main - dns/aardvark-dns: add new port

From: Daniel Engberg <diizzy_at_FreeBSD.org>
Date: Tue, 18 Nov 2025 16:42:15 UTC 
On 2025-11-18 16:59, Sergey A. Osokin wrote:
> The branch main has been updated by osa:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=b4a4910b55ef1d15fa1628aad7141624f967a787
>
> commit b4a4910b55ef1d15fa1628aad7141624f967a787
> Author:     Sergey A. Osokin <osa@FreeBSD.org>
> AuthorDate: 2025-11-18 15:56:43 +0000
> Commit:     Sergey A. Osokin <osa@FreeBSD.org>
> CommitDate: 2025-11-18 15:59:48 +0000
>
>      dns/aardvark-dns: add new port
>      
>      Authoritative dns server for A/AAAA container records. Forwards other
>      request to host's /etc/resolv.conf.  It's mostly intended to be used
>      with netavark which launch it automatically if both are installed.
>      
>      Sponsored by:   tipi.work
> ---
>   dns/Makefile                     |   1 +
>   dns/aardvark-dns/Makefile        |  28 ++++
>   dns/aardvark-dns/Makefile.crates | 174 +++++++++++++++++++
>   dns/aardvark-dns/distinfo        | 351 +++++++++++++++++++++++++++++++++++++++
>   dns/aardvark-dns/pkg-descr       |   2 +
>   5 files changed, 556 insertions(+)
>
> diff --git a/dns/Makefile b/dns/Makefile
> index 79ba0ba3f07e..190723bd4586 100644
> --- a/dns/Makefile
> +++ b/dns/Makefile
> @@ -1,5 +1,6 @@
>       COMMENT = Domain Name Service tools
>   
> +    SUBDIR += aardvark-dns
>       SUBDIR += acme-dns
>       SUBDIR += adns
>       SUBDIR += amass
> diff --git a/dns/aardvark-dns/Makefile b/dns/aardvark-dns/Makefile
> new file mode 100644
> index 000000000000..cb9a7941d096
> --- /dev/null
> +++ b/dns/aardvark-dns/Makefile
> @@ -0,0 +1,28 @@
> +PORTNAME=	aardvark-dns
> +PORTVERSION=	1.17.0
> +DISTVERSIONPREFIX=	v
> +CATEGORIES=	dns
> +
> +MAINTAINER=	osa@FreeBSD.org
> +COMMENT=	Authoritative dns server
> +WWW=		https://github.com/containers/aardvark-dns
> +
> +LICENSE=	APACHE20
> +LICENSE_FILE=	${WRKSRC}/LICENSE
> +
> +LIB_DEPENDS=	libinotify.so:devel/libinotify
> +
> +USES=		cargo
> +
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	containers
> +
> +.if !exists(/usr/include/sys/inotify.h)
> +LDFLAGS+=	-L${LOCALBASE}/lib -linotify
> +.endif
> +
Hi,

This is looks not ideal? :-)
Why is libinotify always pulled in as a dependency if it's in base?
For consistency with the rest of the tree probably better to use 
OSVERSION or OSREL/OSREL:R instead of just checking that it exists.

Best regards
Daniel